Bug 82608 - Chromium: DRT --no-timeout option doesn't work
Summary: Chromium: DRT --no-timeout option doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-29 06:21 PDT by Ilya Tikhonovsky
Modified: 2012-03-29 17:58 PDT (History)
12 users (show)

See Also:

Attachments
Patch (1.52 KB, patch)
2012-03-29 06:24 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
Patch (1.69 KB, patch)
2012-03-29 06:51 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
Patch (1.69 KB, patch)
2012-03-29 07:12 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
Patch (2.02 KB, patch)
2012-03-29 07:27 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-03-29 06:21:59 PDT 
%subj%
Comment 1 Ilya Tikhonovsky 2012-03-29 06:24:51 PDT 
Created attachment 134562 [details]
Patch
Comment 2 Yury Semikhatsky 2012-03-29 06:34:06 PDT 
Comment on attachment 134562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134562&action=review

> Tools/ChangeLog:5
> +

Please provide some description.

> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:251
> +        shell.initialize();

Why initialize is called after all the setters above?
Comment 3 Ilya Tikhonovsky 2012-03-29 06:51:44 PDT 
Created attachment 134568 [details]
Patch
Comment 4 Ilya Tikhonovsky 2012-03-29 07:12:21 PDT 
Created attachment 134573 [details]
Patch
Comment 5 Ilya Tikhonovsky 2012-03-29 07:27:47 PDT 
Created attachment 134579 [details]
Patch
Comment 6 Ilya Tikhonovsky 2012-03-29 11:28:06 PDT 
Comment on attachment 134579 [details]
Patch

Clearing flags on attachment: 134579

Committed r112552: <http://trac.webkit.org/changeset/112552>
Comment 7 Ilya Tikhonovsky 2012-03-29 11:28:15 PDT 
All reviewed patches have been landed.  Closing bug.