Bug 82517 - Bugzilla should provide diffs between two patches
Summary: Bugzilla should provide diffs between two patches
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-28 13:39 PDT by Ryosuke Niwa
Modified: 2014-12-20 12:07 PST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-03-28 13:39:09 PDT
Sometimes, only thing I want to see on the review tool is the difference between two patches because I had already reviewed the previous one.

Bugzilla should provide provide some way to do this.
Comment 1 Eric Seidel (no email) 2012-03-28 13:40:47 PDT
it does!  Click on the "diff" link isntad of pretty diff sometime.
Comment 2 Eric Seidel (no email) 2012-03-28 13:41:56 PDT
I can't say it works very well... (it often fails for me), but it is supposed to solve this exact question. :)
Comment 3 Ojan Vafai 2012-03-28 13:46:03 PDT
In theory, bugzilla lets you do this via https://bugs.webkit.org/attachment.cgi?oldid=129509&action=interdiff&newid=133186&headers=1. But I find that it rarely actually works. Also, what you really want is for it to be integrated into the code review tool so it can show you both the diff between the patches and the comments on the old patch, so you can see that the comments were addressed.
Comment 4 Ryosuke Niwa 2012-03-28 13:46:48 PDT
(In reply to comment #1)
> it does!  Click on the "diff" link isntad of pretty diff sometime.

Ah, I didn't realize that feature. We should probably integrate it with the review tool as well though. (Just adding links might be sufficient). Also, it doesn't seem to work well. e.g. try https://bugs.webkit.org/attachment.cgi?oldid=134350&action=interdiff&newid=134383&headers=1.
Comment 5 David Kilzer (:ddkilzer) 2014-12-15 09:35:35 PST
I just installed interdiff on bugs.webkit.org, so this should be working now.

For example:  https://bugs.webkit.org/attachment.cgi?oldid=243242&action=interdiff&newid=243295&headers=1
Comment 6 Brian Burg 2014-12-20 12:07:08 PST
Doesn't seem to work for this case: https://bugs.webkit.org/attachment.cgi?oldid=242968&action=interdiff&newid=243586&headers=1