Bug 82517 – Bugzilla should provide diffs between two patches

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Website

[Ryosuke Niwa]

Sometimes, only thing I want to see on the review tool is the difference between two patches because I had already reviewed the previous one.

Bugzilla should provide provide some way to do this.

[Eric Seidel (no email)]

it does!  Click on the "diff" link isntad of pretty diff sometime.

[Eric Seidel (no email)]

I can't say it works very well... (it often fails for me), but it is supposed to solve this exact question. :)

[Ojan Vafai]

In theory, bugzilla lets you do this via https://bugs.webkit.org/attachment.cgi?oldid=129509&action=interdiff&newid=133186&headers=1. But I find that it rarely actually works. Also, what you really want is for it to be integrated into the code review tool so it can show you both the diff between the patches and the comments on the old patch, so you can see that the comments were addressed.

[Ryosuke Niwa]

(In reply to comment #1)
> it does!  Click on the "diff" link isntad of pretty diff sometime.

Ah, I didn't realize that feature. We should probably integrate it with the review tool as well though. (Just adding links might be sufficient). Also, it doesn't seem to work well. e.g. try https://bugs.webkit.org/attachment.cgi?oldid=134350&action=interdiff&newid=134383&headers=1.

[David Kilzer (:ddkilzer)]

I just installed interdiff on bugs.webkit.org, so this should be working now.

For example:  https://bugs.webkit.org/attachment.cgi?oldid=243242&action=interdiff&newid=243295&headers=1

[Brian Burg]

Doesn't seem to work for this case: https://bugs.webkit.org/attachment.cgi?oldid=242968&action=interdiff&newid=243586&headers=1