Bug 82267 – Build system prep work for upstreaming iOS changes

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Kilzer (:ddkilzer)]

Created attachment 133934 [details]
Patch

Reviewed by NOBODY (OOPS!).

* DerivedSources.make: Move 'bison' into a variable and use
xcrun to find it on Mac OS X.
* bindings/scripts/preprocessor.pm:
(applyPreprocessor): Add local @args variable.
---
 3 files changed, 27 insertions(+), 4 deletions(-)

[WebKit Review Bot]

Attachment 133934 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Rowe (bdash)]

Comment on attachment 133934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133934&action=review

r=me

> Source/WebCore/ChangeLog:10
> +        (applyPreprocessor): Add local @args variable.

An explanation of the benefit of this @args variable wouldn't hurt.

> Source/WebCore/bindings/scripts/preprocessor.pm:55
> +        $preprocessor = $gccLocation;
> +        push(@args, qw(-E -P -x c++));

It seems like the $gccLocation variable is now redundant.

[David Kilzer (:ddkilzer)]

Committed r112203: <http://trac.webkit.org/changeset/112203>