Bug 82190 - [EFL] DRT support for computedStyleIncludingVisitedInfo
: [EFL] DRT support for computedStyleIncludingVisitedInfo
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit EFL
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Sudarsana Nagineni (babu)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-26 04:40 PDT by Sudarsana Nagineni (babu)
Modified: 2012-05-15 00:20 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.03 KB, patch)
2012-03-26 05:24 PDT, Sudarsana Nagineni (babu)
tonikitoo: review+
webkit.review.bot: commit‑queue-
Details | Formatted Diff | Diff
Patch (6.17 KB, patch)
2012-04-03 21:53 PDT, Sudarsana Nagineni (babu)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2012-03-26 04:40:33 PDT
Implement computedStyleIncludingVisitedInfo for EFL DRT in order to unskip the following tests.

fast/history/multiple-classes-visited.html
fast/history/nested-visited-test.html
fast/history/self-is-visited.html
fast/history/sibling-visited-test.html
fast/loader/stateobjects/state-url-sets-links-visited.html
Comment 1 Sudarsana Nagineni (babu) 2012-03-26 05:24:01 PDT
Created attachment 133782 [details]
Patch

Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
Comment 2 Gyuyoung Kim 2012-03-26 05:45:14 PDT
Comment on attachment 133782 [details]
Patch

Looks good to me.
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-03-26 07:07:27 PDT
Comment on attachment 133782 [details]
Patch

If it works for GTK it probably works for us as well. Thanks for the patch.
Comment 4 WebKit Review Bot 2012-04-03 10:16:27 PDT
Comment on attachment 133782 [details]
Patch

Rejecting attachment 133782 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 11136 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 11136.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/12322234
Comment 5 Sudarsana Nagineni (babu) 2012-04-03 21:53:36 PDT
Created attachment 135510 [details]
Patch

rebased
Comment 6 WebKit Review Bot 2012-04-04 07:12:30 PDT
Comment on attachment 135510 [details]
Patch

Rejecting attachment 135510 [details] from commit-queue.

rakuco@webkit.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 7 Raphael Kubo da Costa (:rakuco) 2012-04-04 07:25:53 PDT
Comment on attachment 135510 [details]
Patch

cq+'ing again after <http://trac.webkit.org/changeset/113186>
Comment 8 Kristóf Kosztyó 2012-04-04 08:22:02 PDT
Comment on attachment 135510 [details]
Patch

Rejecting attachment 135510 [details] from commit-queue.

rakuco@webkit.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 9 Raphael Kubo da Costa (:rakuco) 2012-04-04 09:05:06 PDT
Manually landed <http://trac.webkit.org/changeset/113198>.