Bug 82190 – [EFL] DRT support for computedStyleIncludingVisitedInfo

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Sudarsana Nagineni (babu)]

Implement computedStyleIncludingVisitedInfo for EFL DRT in order to unskip the following tests.

fast/history/multiple-classes-visited.html
fast/history/nested-visited-test.html
fast/history/self-is-visited.html
fast/history/sibling-visited-test.html
fast/loader/stateobjects/state-url-sets-links-visited.html

[Sudarsana Nagineni (babu)]

Created attachment 133782 [details]
Patch

Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport

[Gyuyoung Kim]

Comment on attachment 133782 [details]
Patch

Looks good to me.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 133782 [details]
Patch

If it works for GTK it probably works for us as well. Thanks for the patch.

[WebKit Review Bot]

Comment on attachment 133782 [details]
Patch

Rejecting attachment 133782 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 11136 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 11136.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/12322234

[Sudarsana Nagineni (babu)]

Created attachment 135510 [details]
Patch

rebased

[WebKit Review Bot]

Comment on attachment 135510 [details]
Patch

Rejecting attachment 135510 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 135510 [details]
Patch

cq+'ing again after <http://trac.webkit.org/changeset/113186>

[Kristóf Kosztyó]

Comment on attachment 135510 [details]
Patch

Rejecting attachment 135510 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Raphael Kubo da Costa (:rakuco)]

Manually landed <http://trac.webkit.org/changeset/113198>.