Bug 82174 - [EFL][DRT] Catch the "title,changed" signal
Summary: [EFL][DRT] Catch the "title,changed" signal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-26 01:29 PDT by Chris Dumez
Modified: 2012-05-06 22:47 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch (3.66 KB, patch)
2012-03-26 01:44 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Proposed patch (2.82 KB, patch)
2012-04-05 01:07 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-03-26 01:29:01 PDT 
EFL's DRT (DumpRenderTreeChrome) needs to catch the "title,changed" signal and so that the following test cases no longer need to be skipped:
- fast/dom/title-text-property.html
- fast/dom/title-text-property-2.html
Comment 1 Chris Dumez 2012-03-26 01:44:45 PDT 
Created attachment 133749 [details]
Proposed patch
Comment 2 Gyuyoung Kim 2012-03-26 01:55:38 PDT 
Comment on attachment 133749 [details]
Proposed patch

Looks good to me.
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-03-26 07:03:22 PDT 
Comment on attachment 133749 [details]
Proposed patch

Looks fine, thanks for the patch.
Comment 4 Chris Dumez 2012-04-05 01:07:04 PDT 
Created attachment 135777 [details]
Proposed patch

Rebase on master and update changelogs.
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-04-05 08:45:52 PDT 
Comment on attachment 135777 [details]
Proposed patch

Looks good.
Comment 6 WebKit Review Bot 2012-04-10 09:22:40 PDT 
Comment on attachment 135777 [details]
Proposed patch

Clearing flags on attachment: 135777

Committed r113724: <http://trac.webkit.org/changeset/113724>
Comment 7 WebKit Review Bot 2012-04-10 09:22:45 PDT 
All reviewed patches have been landed.  Closing bug.