Add maxNumberOfChannels interface to audioDestinationNode.

[Raymond]

Add maxNumberOfChannels interface to audioDestinationNode.

[Raymond]

Created attachment 133719 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Raymond]

Hi Chris

According to what we have discussed before, I create this patch to add a maxNumberOfChannels interface to audioDestinationNode. Dummy implementation provided for mac and gstreamer destination. chromium destination will call into webkitPlatformSupport, which I will be glad to implement later in chromium code base if this patch looks good to you.

I don't touch the part for setting the destinationnode's channels number ( say, change numberOfChannels interface from readonly to read write). This part still need more investigation to find out how much impact it will bring to the current audio processing implementation. Any idea or guideline on this part?

[Raymond]

Hi Chris

Any idea on this patch?

[Raymond]

Created attachment 146212 [details]
Patch

[Raymond]

Hi Chris

Patch updated for maxNumberOfChannels and numberOfChannels interface to audioDestinationNode.

Since the working solution involves changes to chromium code. In this patch it only provide default dummy implementation for them.

And also, change numberOfChannels on fly seems really hard to implement, so there is a limit in this patch that you can only change numberOfChannels right after the context is created ( thus not initialized yet, after initialize, a Dom exception will be thrown if user want to change the numberOfChannels)

[Build Bot]

Comment on attachment 146212 [details]
Patch

Attachment 146212 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12913125

[Raymond]

Created attachment 146222 [details]
Patch

[Raymond]

update patch for warning on mac

[Build Bot]

Comment on attachment 146222 [details]
Patch

Attachment 146222 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12922060

[Raymond]

Created attachment 146228 [details]
Patch

[Raymond]

oops, patch updated again for mac build.

hmm, does a webkit committer have the right to access try bot? really inconvenient and annoying to upload patch and verify build on other platform...

I have 20 patches landed now, any process to apply for committer role?

[Raymond]

Created attachment 146235 [details]
Patch

[WebKit Review Bot]

Comment on attachment 146235 [details]
Patch

Attachment 146235 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12908332

[Raymond]

Created attachment 146443 [details]
Patch

[Philippe Normand]

Comment on attachment 146443 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=146443&action=review

> Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.cpp:96
> +    (void) numberOfChannels;
> +    (void) ec;

You can use the UNUSED_PARAM() macro.

[Chris Rogers]

This patch is obsolete -- implemented here:
http://trac.webkit.org/changeset/144720

[Zan Dobersek]

Comment on attachment 146443 [details]
Patch

The work on this bug has ceased, removing the r? flag on the patch.