Bug 82015 - Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl (Part 1)
Summary: Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl (Par...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 79636
  Show dependency tree / graph
 
Reported: 2012-03-22 22:35 PDT by Adam Barth
Modified: 2012-03-22 23:29 PDT (History)
5 users (show)

See Also:

Attachments
Patch (24.96 KB, patch)
2012-03-22 22:40 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-03-22 22:35:29 PDT 
Move Notifications APIs from DOMWindow.idl to DOMWindowNotifications.idl (Part 1)
Comment 1 Adam Barth 2012-03-22 22:40:09 PDT 
Created attachment 133432 [details]
Patch
Comment 2 Kentaro Hara 2012-03-22 22:49:32 PDT 
Comment on attachment 133432 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=133432&action=review

> Source/WebCore/notifications/DOMWindowNotifications.h:32
> +#include "DOMWindowProperty.h"

Nit: This wouldn't be necessary in this patch, but it is OK. You'll add it in the next patch.
Comment 3 Adam Barth 2012-03-22 22:50:06 PDT 
Yeah.  :)
Comment 4 WebKit Review Bot 2012-03-22 23:29:33 PDT 
Comment on attachment 133432 [details]
Patch

Clearing flags on attachment: 133432

Committed r111832: <http://trac.webkit.org/changeset/111832>
Comment 5 WebKit Review Bot 2012-03-22 23:29:38 PDT 
All reviewed patches have been landed.  Closing bug.