Bug 81923 - Web Inspector: Migrate InspectorCSSAgent to strict protocol types
Summary: Web Inspector: Migrate InspectorCSSAgent to strict protocol types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-22 09:04 PDT by Alexander Pavlov (apavlov)
Modified: 2012-03-26 07:05 PDT (History)
10 users (show)

See Also:


Attachments
Patch (46.79 KB, patch)
2012-03-22 11:11 PDT, Alexander Pavlov (apavlov)
no flags Details | Formatted Diff | Diff
Patch (46.91 KB, patch)
2012-03-23 02:38 PDT, Alexander Pavlov (apavlov)
pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2012-03-22 09:04:09 PDT
Patch to follow.
Comment 1 Alexander Pavlov (apavlov) 2012-03-22 11:11:06 PDT
Created attachment 133297 [details]
Patch
Comment 2 Build Bot 2012-03-22 11:31:43 PDT
Comment on attachment 133297 [details]
Patch

Attachment 133297 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12117147
Comment 3 Alexander Pavlov (apavlov) 2012-03-23 02:38:32 PDT
Created attachment 133449 [details]
Patch
Comment 4 WebKit Review Bot 2012-03-26 02:05:02 PDT
Comment on attachment 133449 [details]
Patch

Rejecting attachment 133449 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 file Source/WebCore/inspector/InspectorStyleSheet.cpp
Hunk #11 FAILED at 837.
Hunk #12 succeeded at 918 (offset -1 lines).
Hunk #13 succeeded at 932 (offset -1 lines).
1 out of 13 hunks FAILED -- saving rejects to file Source/WebCore/inspector/InspectorStyleSheet.cpp.rej
patching file Source/WebCore/inspector/InspectorStyleSheet.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Pavel Feld..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12132669
Comment 5 Alexander Pavlov (apavlov) 2012-03-26 07:05:04 PDT
Committed r112087: <http://trac.webkit.org/changeset/112087>