WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
81862
REGRESSION(
r111616
): broke chromium mac (Requested by eae on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=81862
Summary
REGRESSION(r111616): broke chromium mac (Requested by eae on #webkit).
WebKit Review Bot
Reported
2012-03-21 18:37:56 PDT
http://trac.webkit.org/changeset/111616
broke the build: broke chromium mac (Requested by eae on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r111616
(57.69 KB, patch)
2012-03-21 18:38 PDT
,
WebKit Review Bot
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
WebKit Review Bot
Comment 1
2012-03-21 18:38:28 PDT
Created
attachment 133165
[details]
ROLLOUT of
r111616
Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Emil A Eklund
Comment 2
2012-03-21 18:40:29 PDT
/Users/chrome-bot/Desktop/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/tests/CCAnimationTestCommon.cpp:65:87: error: reference to 'Fixed' is ambiguous operations.operations().append(TranslateTransformOperation::create(Length(deltaX, Fixed), Length(deltaY, Fixed), TransformOperation::TRANSLATE_X)); ^ /Developer/SDKs/MacOSX10.5.sdk/System/Library/Frameworks/CoreServices.framework/Headers/../Frameworks/CarbonCore.framework/Headers/MacTypes.h:163:41: note: candidate found by name lookup is 'Fixed' typedef SInt32 Fixed; ^ ../../WebCore/platform/Length.h:36:44: note: candidate found by name lookup is 'WebCore::LengthType::Fixed' enum LengthType { Auto, Relative, Percent, Fixed, Intrinsic, MinIntrinsic, Calculated, Undefined }; ^ 1 error generated.
Emil A Eklund
Comment 3
2012-03-21 18:44:11 PDT
Comment on
attachment 133165
[details]
ROLLOUT of
r111616
Clearing flags on attachment: 133165 Committed
r111638
: <
http://trac.webkit.org/changeset/111638
>
Emil A Eklund
Comment 4
2012-03-21 18:44:14 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug