Bug 81557 - [chromium] Remove misleading double-if
Summary: [chromium] Remove misleading double-if
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dana Jansens
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-19 13:54 PDT by Dana Jansens
Modified: 2012-03-19 15:27 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.89 KB, patch)
2012-03-19 13:54 PDT, Dana Jansens 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dana Jansens 2012-03-19 13:54:16 PDT 
[chromium] Remove misleading double-if
Comment 1 Dana Jansens 2012-03-19 13:54:59 PDT 
Created attachment 132660 [details]
Patch
Comment 2 Dana Jansens 2012-03-19 13:56:13 PDT 
The code does the following:

m_paintRect = dirtyLayerRect;
if (dirtyLayerRect.isEmpty())
    return;
// Now we know dirtyLayerRect is not empty. Thus m_paintRect is not empty. The check below is always true.
if (!m_paintRect.isEmpty())
    m_requestedUpdateTilesRect = IntRect(left, top, right - left + 1, bottom - top + 1);
Comment 3 Adrienne Walker 2012-03-19 14:09:19 PDT 
Comment on attachment 132660 [details]
Patch

Yeah, that check looks totally unnecessary.
Comment 4 WebKit Review Bot 2012-03-19 15:27:40 PDT 
Comment on attachment 132660 [details]
Patch

Clearing flags on attachment: 132660

Committed r111260: <http://trac.webkit.org/changeset/111260>
Comment 5 WebKit Review Bot 2012-03-19 15:27:44 PDT 
All reviewed patches have been landed.  Closing bug.