Bug 81534 - [New Multicolumn] Make columns relayout properly when the containing block width changes.
Summary: [New Multicolumn] Make columns relayout properly when the containing block wi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-19 12:07 PDT by Dave Hyatt
Modified: 2012-03-19 12:28 PDT (History)
2 users (show)

See Also:


Attachments
Patch (6.68 KB, patch)
2012-03-19 12:12 PDT, Dave Hyatt
no flags Details | Formatted Diff | Diff
Patch (6.67 KB, patch)
2012-03-19 12:16 PDT, Dave Hyatt
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2012-03-19 12:07:48 PDT
Make columns relayout properly when the containing block width changes. Cache the column count and width on the multi-column block.
Comment 1 Dave Hyatt 2012-03-19 12:12:43 PDT
Created attachment 132623 [details]
Patch
Comment 2 Dave Hyatt 2012-03-19 12:16:15 PDT
Created attachment 132624 [details]
Patch
Comment 3 WebKit Review Bot 2012-03-19 12:18:32 PDT
Attachment 132624 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/rendering/RenderMultiColumnBlock.h:45:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Antti Koivisto 2012-03-19 12:21:41 PDT
r=me
Comment 5 Dave Hyatt 2012-03-19 12:28:58 PDT
Fixed in r111217.