Bug 81324 - Rename getElementInShadowTreeStack to getNodeInShadowTreeStack
Summary: Rename getElementInShadowTreeStack to getNodeInShadowTreeStack
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P4 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-16 02:43 PDT by Kaustubh Atrawalkar
Modified: 2012-03-21 00:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.03 KB, patch)
2012-03-20 03:47 PDT, Kaustubh Atrawalkar 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kaustubh Atrawalkar 2012-03-16 02:43:40 PDT 
With reference to the comments from Hayato in bug https://bugs.webkit.org/show_bug.cgi?id=81102, 
"We should rename getElementInShadowTreeStack since it can return ShadowRoot, which is not Element.
That is an unintentional usage that it can return ShadowRoot. So we should rename it to getNodeInShadowTreeStack."
Comment 1 Kaustubh Atrawalkar 2012-03-20 03:47:17 PDT 
Created attachment 132790 [details]
Patch
Comment 2 Hayato Ito 2012-03-20 18:06:43 PDT 
Okay. You need r+ from reviewers.

(In reply to comment #1)
> Created an attachment (id=132790) [details]
> Patch
Comment 3 WebKit Review Bot 2012-03-21 00:06:21 PDT 
Comment on attachment 132790 [details]
Patch

Clearing flags on attachment: 132790

Committed r111505: <http://trac.webkit.org/changeset/111505>
Comment 4 WebKit Review Bot 2012-03-21 00:06:25 PDT 
All reviewed patches have been landed.  Closing bug.