WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
81324
Rename getElementInShadowTreeStack to getNodeInShadowTreeStack
https://bugs.webkit.org/show_bug.cgi?id=81324
Summary
Rename getElementInShadowTreeStack to getNodeInShadowTreeStack
Kaustubh Atrawalkar
Reported
2012-03-16 02:43:40 PDT
With reference to the comments from Hayato in bug
https://bugs.webkit.org/show_bug.cgi?id=81102
, "We should rename getElementInShadowTreeStack since it can return ShadowRoot, which is not Element. That is an unintentional usage that it can return ShadowRoot. So we should rename it to getNodeInShadowTreeStack."
Attachments
Patch
(7.03 KB, patch)
2012-03-20 03:47 PDT
,
Kaustubh Atrawalkar
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kaustubh Atrawalkar
Comment 1
2012-03-20 03:47:17 PDT
Created
attachment 132790
[details]
Patch
Hayato Ito
Comment 2
2012-03-20 18:06:43 PDT
Okay. You need r+ from reviewers. (In reply to
comment #1
)
> Created an attachment (id=132790) [details] > Patch
WebKit Review Bot
Comment 3
2012-03-21 00:06:21 PDT
Comment on
attachment 132790
[details]
Patch Clearing flags on attachment: 132790 Committed
r111505
: <
http://trac.webkit.org/changeset/111505
>
WebKit Review Bot
Comment 4
2012-03-21 00:06:25 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug