Bug 8119 - icu directory causes inclusion of apple specific headers
Summary: icu directory causes inclusion of apple specific headers
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 420+
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-01 08:42 PST by Michael Emmel
Modified: 2013-07-09 09:50 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Emmel 2006-04-01 08:42:03 PST
In my build for linux I need to include the toplevel path to pick up config.h
But this means that the icu directory is now in the include path which can cause inclusion of the apple specific icu headers instead of system supplied ones.

Would it be possible to move this directory somewhere where it won't intefere with other ports ?
Comment 1 Justin Haygood 2006-04-01 20:27:37 PST
This shouldn't be an issue, ICU includes are via <unicode/bla> not <icu/unicode/bla>, even on linux distros (check /usr/include/ or /usr/local/include/.. should have unicode dirs for ICU, not ICU dirs)
Comment 2 Michael Emmel 2006-04-01 22:45:33 PST
I think your right.

I only got a build by deleting this directory.
What I'm seeing with it inplace is that the webcore_* symbols are picked
up from the headers in icu.
In anycase I still consider these plaform specific headers that should be I think
be under platform/mac/icu not toplevel.

I do need to figure out why there getting picked up but moving them is the right thing still  IMHO.
Comment 3 Alexey Proskuryakov 2013-07-09 09:50:10 PDT
Sounds like this hasn't been an issue lately.