Bug 80997 - [GTK] Use the same DNS prefetching path than the other ports.
Summary: [GTK] Use the same DNS prefetching path than the other ports.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-13 09:00 PDT by Sergio Villar Senin
Modified: 2012-03-14 00:32 PDT (History)
6 users (show)

See Also:


Attachments
Patch (11.86 KB, patch)
2012-03-13 10:56 PDT, Sergio Villar Senin
mrobinson: review+
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2012-03-13 09:00:01 PDT
After https://bugs.webkit.org/show_bug.cgi?id=35589 the GTK+ port is using a different code path than the other ports for DNS pre-fetching. It was done back then because there were plans to add some features to soup_session_prepare_for_uri() that would require a full URL instead of just the host name. That work in libsoup was tracked in bug https://bugzilla.gnome.org/show_bug.cgi?id=605065.

After reviewing both patches and double checking with Dan, we agreed that it does not longer make any sense as adding more features to _prepare_for_uri() is really unlikely now.

So it looks like going back to the previous state, and thus, using the same code paths than the other ports is desirable.
Comment 1 Sergio Villar Senin 2012-03-13 10:56:52 PDT
Created attachment 131670 [details]
Patch
Comment 2 Sergio Villar Senin 2012-03-13 10:59:17 PDT
BTW another advantage of this "revert" is that it brings DNSSoup.cpp back to life. That would be the perfect place to host the DNS prefetching queue that will fix bug #80587  or bug #41630
Comment 3 Gyuyoung Kim 2012-03-14 00:12:24 PDT
Comment on attachment 131670 [details]
Patch

Attachment 131670 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11953018
Comment 4 Sergio Villar Senin 2012-03-14 00:24:03 PDT
Committed r110669: <http://trac.webkit.org/changeset/110669>
Comment 5 Sergio Villar Senin 2012-03-14 00:32:37 PDT
(In reply to comment #3)
> (From update of attachment 131670 [details])
> Attachment 131670 [details] did not pass efl-ews (efl):
> Output: http://queues.webkit.org/results/11953018

I forgot to update EFL's PlatformEfl.cmake. Should be fixed in r110671