Bug 80864 - New PageCache histogram which counts failures ignoring Settings.
Summary: New PageCache histogram which counts failures ignoring Settings.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Peters
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-12 12:02 PDT by Gavin Peters
Modified: 2012-03-13 08:29 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.82 KB, patch)
2012-03-12 12:04 PDT, Gavin Peters 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Peters 2012-03-12 12:02:54 PDT 
New PageCache histogram which counts failures ignoring Settings.
Comment 1 Gavin Peters 2012-03-12 12:04:38 PDT 
Created attachment 131375 [details]
Patch
Comment 2 Gavin Peters 2012-03-12 12:07:22 PDT 
Chrome has a command line switch to turn on the page cache. Currently it doesn't work, but it can cause the PageCache reasons for failure count to read lower than it should.  Add a new histogram to report the corrected value.
Comment 3 Gavin Peters 2012-03-12 12:08:13 PDT 
beidson,

Two questions:

1. Do you want to review histogram changes?

2. WDYT?
Comment 4 Brady Eidson 2012-03-12 12:31:02 PDT 
(In reply to comment #3)
> beidson,
> 
> Two questions:
> 
> 1. Do you want to review histogram changes?
>

Sure
 
> 2. WDYT?

Will look after lunch.
Comment 5 WebKit Review Bot 2012-03-13 08:29:11 PDT 
Comment on attachment 131375 [details]
Patch

Clearing flags on attachment: 131375

Committed r110567: <http://trac.webkit.org/changeset/110567>
Comment 6 WebKit Review Bot 2012-03-13 08:29:15 PDT 
All reviewed patches have been landed.  Closing bug.