Bug 80831 - [Blackberry] Make the process of marking all matches interruptible and asynchronous for find-in-page
Summary: [Blackberry] Make the process of marking all matches interruptible and asynch...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-12 06:07 PDT by Andy Chen
Modified: 2012-03-12 15:38 PDT (History)
3 users (show)

See Also:

Attachments
patch (14.14 KB, patch)
2012-03-12 12:09 PDT, Andy Chen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Chen 2012-03-12 06:07:42 PDT 
The function needs to be interruptible.
Comment 1 Andy Chen 2012-03-12 12:09:12 PDT 
Created attachment 131376 [details]
patch
Comment 2 Antonio Gomes 2012-03-12 15:01:07 PDT 
Comment on attachment 131376 [details]
patch

We are having way to many bool parameters and class members set here and there, whereas it seems to me we actually need a kind of state machine of some sort.

Lets considering cleaning it up at some point please.
Comment 3 WebKit Review Bot 2012-03-12 15:38:23 PDT 
Comment on attachment 131376 [details]
patch

Clearing flags on attachment: 131376

Committed r110492: <http://trac.webkit.org/changeset/110492>
Comment 4 WebKit Review Bot 2012-03-12 15:38:28 PDT 
All reviewed patches have been landed.  Closing bug.