Bug 80643 - remove graphics_type from webkitpy.layout_tests.models.test_configuration
Summary: remove graphics_type from webkitpy.layout_tests.models.test_configuration
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
Depends on:
Blocks: 76501
  Show dependency treegraph
Reported: 2012-03-08 14:47 PST by Dirk Pranke
Modified: 2012-03-12 17:50 PDT (History)
5 users (show)

See Also:

Patch (76.46 KB, patch)
2012-03-08 14:48 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-03-08 14:47:02 PST
remove graphics_type from webkitpy.layout_tests.models.test_configuration
Comment 1 Dirk Pranke 2012-03-08 14:48:07 PST
Created attachment 130909 [details]
Comment 2 Dirk Pranke 2012-03-08 14:50:18 PST
Most of this change is straightforward; the only parts you might have to stare at are the tests in test_expectations_editor_unittest and gardeningserver_unittest.py, to make sure that the test combinations are still meaningful and maintain coverage.
Comment 3 Ojan Vafai 2012-03-08 15:35:04 PST
Comment on attachment 130909 [details]

Comment 4 Dirk Pranke 2012-03-12 17:45:09 PDT
This landed in r110000. Not sure why this didn't get updated.
Comment 5 Dirk Pranke 2012-03-12 17:45:42 PDT
er, hm. no it didn't.
Comment 6 Dirk Pranke 2012-03-12 17:50:35 PDT
Committed r110514: <http://trac.webkit.org/changeset/110514>