Bug 80220 - [Qt][WK2] Crashing the web-process may cause the UI process to crash
Summary: [Qt][WK2] Crashing the web-process may cause the UI process to crash
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2012-03-04 08:34 PST by Noam Rosenthal
Modified: 2012-04-10 06:13 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-03-04 08:34:58 PST 
That is because TextureMapperShaderManager gets deleted when its ref from TextureMapperGL is deleted.
We need to make the correct context current before releasing the shaders.
Comment 1 Yael 2012-03-04 17:33:10 PST 
Can you add steps to reproduce the problem?
I enabled frame flattening in MiniBrowser and went to sites like http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_iframe, which crash the web process when frame flattening is on. However, I was able to load a new url and continue browsing after the web process crash.
thanks!
Comment 2 Noam Rosenthal 2012-03-04 17:49:50 PST 
(In reply to comment #1)
> Can you add steps to reproduce the problem?
> I enabled frame flattening in MiniBrowser and went to sites like http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_iframe, which crash the web process when frame flattening is on. However, I was able to load a new url and continue browsing after the web process crash.
> thanks!

Not sure; It might be only happening on Mac.
Comment 3 Yael 2012-03-04 17:53:48 PST 
(In reply to comment #2)
> (In reply to comment #1)
> > Can you add steps to reproduce the problem?
> > I enabled frame flattening in MiniBrowser and went to sites like http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_iframe, which crash the web process when frame flattening is on. However, I was able to load a new url and continue browsing after the web process crash.
> > thanks!
> 
> Not sure; It might be only happening on Mac.

I can post a patch tomorrow, do you mind helping me test it?
Comment 4 Noam Rosenthal 2012-03-04 18:00:22 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > Can you add steps to reproduce the problem?
> > > I enabled frame flattening in MiniBrowser and went to sites like http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_iframe, which crash the web process when frame flattening is on. However, I was able to load a new url and continue browsing after the web process crash.
> > > thanks!
> > 
> > Not sure; It might be only happening on Mac.
> 
> I can post a patch tomorrow, do you mind helping me test it?

Might not be necessary. I have a new patch for threaded-rendering that fixes this as a side effect :)
Comment 5 Yael 2012-03-04 18:07:37 PST 
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (In reply to comment #1)
> > > > Can you add steps to reproduce the problem?
> > > > I enabled frame flattening in MiniBrowser and went to sites like http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_iframe, which crash the web process when frame flattening is on. However, I was able to load a new url and continue browsing after the web process crash.
> > > > thanks!
> > > 
> > > Not sure; It might be only happening on Mac.
> > 
> > I can post a patch tomorrow, do you mind helping me test it?
> 
> Might not be necessary. I have a new patch for threaded-rendering that fixes this as a side effect :)

Great, thanks :)
Comment 6 Yael 2012-04-10 06:08:24 PDT 
Noam, is this still an issue?