Bug 80139 - Revert SVG-related APIs from DOMWindowSVG.idl back to DOMWindow.idl
Summary: Revert SVG-related APIs from DOMWindowSVG.idl back to DOMWindow.idl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 79327
  Show dependency tree / graph
 
Reported: 2012-03-02 03:41 PST by Kentaro Hara
Modified: 2012-03-04 18:35 PST (History)
6 users (show)

See Also:

Attachments
Patch (28.82 KB, patch)
2012-03-02 03:44 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Patch (28.86 KB, patch)
2012-03-02 03:59 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
patch for landing (28.92 KB, patch)
2012-03-04 16:54 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-03-02 03:41:42 PST 
Based on the discussion on webkit-dev@ (http://markmail.org/message/kagvswmah67zmrry#query:+page:1+mid:h34vzbiu5suub3ld+state:results), we should revert SVG-related APIs from DOMWindowSVG.idl back to DOMWindow.idl.
Comment 1 Kentaro Hara 2012-03-02 03:44:05 PST 
Created attachment 129867 [details]
Patch
Comment 2 Kentaro Hara 2012-03-02 03:59:31 PST 
Created attachment 129870 [details]
Patch
Comment 3 Adam Barth 2012-03-02 09:12:00 PST 
Comment on attachment 129870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129870&action=review

> Source/WebCore/page/DOMWindow.idl:495
> +        attribute SVGZoomEventConstructor SVGZoomEvent;

This one is outside the ifdef?
Comment 4 Kentaro Hara 2012-03-04 16:54:23 PST 
Created attachment 130034 [details]
patch for landing
Comment 5 Kentaro Hara 2012-03-04 16:54:57 PST 
Comment on attachment 129870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129870&action=review

>> Source/WebCore/page/DOMWindow.idl:495
>> +        attribute SVGZoomEventConstructor SVGZoomEvent;
> 
> This one is outside the ifdef?

Fixed it and committed. Thanks!
Comment 6 WebKit Review Bot 2012-03-04 18:33:43 PST 
Comment on attachment 130034 [details]
patch for landing

Clearing flags on attachment: 130034

Committed r109693: <http://trac.webkit.org/changeset/109693>