Bug 79688 - Rename DOMSelection to Selection
Summary: Rename DOMSelection to Selection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-27 11:38 PST by Erik Arvidsson
Modified: 2012-03-13 17:22 PDT (History)
3 users (show)

See Also:


Attachments
Patch (23.12 KB, patch)
2012-02-29 15:18 PST, Erik Arvidsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2012-02-27 11:38:43 PST
Both IE and Moz call DOMSelection Selection.
Comment 1 Erik Arvidsson 2012-02-29 15:18:49 PST
Created attachment 129529 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-29 21:34:51 PST
Comment on attachment 129529 [details]
Patch

Clearing flags on attachment: 129529

Committed r109306: <http://trac.webkit.org/changeset/109306>
Comment 3 WebKit Review Bot 2012-02-29 21:34:56 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Alexey Proskuryakov 2012-03-13 17:22:20 PDT
Comment on attachment 129529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129529&action=review

> Source/WebCore/page/DOMWindow.idl:397
>          attribute DOMWindowConstructor Window;

This change wasn't mentioned in bug or in ChangeLog, and broke regression tests.

In the future, please do describe changes like this one.