Bug 79685 - [CSSRegions][CSSOM]Prevent creation of NamedFlow object for invalid flow name
Summary: [CSSRegions][CSSOM]Prevent creation of NamedFlow object for invalid flow name
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 57312
  Show dependency treegraph
 
Reported: 2012-02-27 11:01 PST by Mihnea Ovidenie
Modified: 2012-07-23 23:39 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.48 KB, patch)
2012-02-27 12:03 PST, Mihnea Ovidenie
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch 2 (6.56 KB, patch)
2012-03-01 02:21 PST, Mihnea Ovidenie
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mihnea Ovidenie 2012-02-27 11:01:38 PST
http://dev.w3.org/csswg/css3-regions/#flow-into
" The values ‘none’, ‘inherit’, ‘default’, ‘auto’ and ‘initial’ are invalid flow names." Therefore, asking for a named flow object with such a name should return a null object.
Comment 1 Mihnea Ovidenie 2012-02-27 12:03:21 PST
Created attachment 129080 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-27 13:40:18 PST
Comment on attachment 129080 [details]
Patch

Attachment 129080 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11643170

New failing tests:
css3/filters/effect-invert-hw.html
Comment 3 Mihnea Ovidenie 2012-03-01 02:21:20 PST
Created attachment 129669 [details]
Patch 2
Comment 4 Dave Hyatt 2012-03-05 13:39:30 PST
Comment on attachment 129669 [details]
Patch 2

r=me
Comment 5 WebKit Review Bot 2012-03-05 15:32:08 PST
Comment on attachment 129669 [details]
Patch 2

Clearing flags on attachment: 129669

Committed r109807: <http://trac.webkit.org/changeset/109807>
Comment 6 WebKit Review Bot 2012-03-05 15:32:13 PST
All reviewed patches have been landed.  Closing bug.