Bug 79132 - Convert some fast/regions pixel tests to reftests
Summary: Convert some fast/regions pixel tests to reftests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-21 11:11 PST by Rebecca Hauck
Modified: 2012-03-12 15:25 PDT (History)
3 users (show)

See Also:

Attachments
Patch for the bug (71.15 KB, patch)
2012-02-24 17:18 PST, Rebecca Hauck 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Fixed failure - added missing file (73.70 KB, patch)
2012-03-02 11:50 PST, Rebecca Hauck 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rebecca Hauck 2012-02-21 11:11:21 PST 
Convert some fast/regions pixel tests to reftests
Comment 1 Rebecca Hauck 2012-02-24 17:18:26 PST 
Created attachment 128833 [details]
Patch for the bug
Comment 2 WebKit Review Bot 2012-02-24 18:11:15 PST 
Comment on attachment 128833 [details]
Patch for the bug

Attachment 128833 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11630250
Comment 3 Rebecca Hauck 2012-03-02 11:50:17 PST 
Created attachment 129933 [details]
Fixed failure - added missing file

Added the missing -expected.html file
Comment 4 Dirk Schulze 2012-03-12 14:57:36 PDT 
Comment on attachment 129933 [details]
Fixed failure - added missing file

Great alternative! r=me

At some point the formatted diff should be extended to show static versions of the file. That makes it easier for reviewers to see what happens.
Comment 5 WebKit Review Bot 2012-03-12 15:24:59 PDT 
Comment on attachment 129933 [details]
Fixed failure - added missing file

Clearing flags on attachment: 129933

Committed r110489: <http://trac.webkit.org/changeset/110489>
Comment 6 WebKit Review Bot 2012-03-12 15:25:04 PDT 
All reviewed patches have been landed.  Closing bug.