Bug 78538 - CSS 2.1 failure: eof-003.htm fails
Summary: CSS 2.1 failure: eof-003.htm fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Hogan
URL:
Keywords:
: 34067 34723 (view as bug list)
Depends on:
Blocks: 47141
  Show dependency tree / graph
 
Reported: 2012-02-13 14:16 PST by Robert Hogan
Modified: 2012-03-18 04:33 PDT (History)
11 users (show)

See Also:

Attachments
Patch (4.76 KB, patch)
2012-02-13 14:44 PST, Robert Hogan 		no flags Details | Formatted Diff | Diff
Patch (4.75 KB, patch)
2012-02-13 15:08 PST, Robert Hogan 		no flags Details | Formatted Diff | Diff
Patch (16.06 KB, patch)
2012-02-14 14:27 PST, Robert Hogan 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2012-02-13 14:16:47 PST 
The new CSS lexer can handle this I'm sure.
Comment 1 Robert Hogan 2012-02-13 14:17:05 PST 
*** Bug 34723 has been marked as a duplicate of this bug. ***
Comment 2 Robert Hogan 2012-02-13 14:20:35 PST 
*** Bug 34067 has been marked as a duplicate of this bug. ***
Comment 3 Alexey Proskuryakov 2012-02-13 14:28:57 PST 
Why did you reverse dupe to the newer bug? It's generally advisable to keep older one open.
Comment 4 Robert Hogan 2012-02-13 14:44:00 PST 
Created attachment 126841 [details]
Patch
Comment 5 Robert Hogan 2012-02-13 14:46:17 PST 
(In reply to comment #3)
> Why did you reverse dupe to the newer bug? It's generally advisable to keep older one open.

The larger of the two is invalid now as the lexer has been rewritten so felt it would be easier to navigate a clean copy for this patch review. But yes, fair point.
Comment 6 Robert Hogan 2012-02-13 15:08:29 PST 
Created attachment 126845 [details]
Patch
Comment 7 Robert Hogan 2012-02-14 14:27:04 PST 
Created attachment 127046 [details]
Patch
Comment 8 Robert Hogan 2012-02-20 12:56:05 PST 
Hi Zoltan,

Could you take a look when you get the chance?
Comment 9 Robert Hogan 2012-03-08 22:50:41 PST 
Hi Antti/Oliver,

Could either of you take a look at this one please?

Thanks,
Robert
Comment 10 Antti Koivisto 2012-03-17 04:10:52 PDT 
Comment on attachment 127046 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127046&action=review

r=me

> Source/WebCore/ChangeLog:13
> +
> +        CSS 2.1 failure: eof-003.htm fails
> +        https://bugs.webkit.org/show_bug.cgi?id=78538
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Tests: css2.1/20110323/eof-001.htm
> +               css2.1/20110323/eof-003.htm
> +               css2.1/20110323/eof-004.htm
> +               css2.1/20110323/eof-005.htm
> +               css2.1/20110323/eof-006.htm
> +               css2.1/20110323/eof-007.htm

Some of there worked already. Please mention which ones were fixed.
Comment 11 Robert Hogan 2012-03-18 04:33:42 PDT 
Committed r111132: <http://trac.webkit.org/changeset/111132>