Bug 78490 - Rename [JSGenerateToJS] to [JSGenerateToJSObject]
Summary: Rename [JSGenerateToJS] to [JSGenerateToJSObject]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 77393
  Show dependency treegraph
 
Reported: 2012-02-13 06:05 PST by Kentaro Hara
Modified: 2012-02-14 18:06 PST (History)
5 users (show)

See Also:


Attachments
Patch (20.94 KB, patch)
2012-02-13 06:07 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
rebased patch for commit (20.94 KB, patch)
2012-02-14 16:48 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-13 06:05:18 PST
We can rename [JSGenerateToJS] to [JSGenerateToJSObject], for naming consistency with [CustomToJSObject], [JSCustomToJSObject] and [V8CustomToJSObject].
Comment 1 Kentaro Hara 2012-02-13 06:07:10 PST
Created attachment 126764 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-13 16:44:34 PST
Comment on attachment 126764 [details]
Patch

Rejecting attachment 126764 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
e/webaudio/MediaElementAudioSourceNode.idl
patching file Source/WebCore/webaudio/OfflineAudioCompletionEvent.idl
patching file Source/WebCore/webaudio/RealtimeAnalyserNode.idl
patching file Source/WebCore/webaudio/WaveShaperNode.idl
patching file Source/WebCore/workers/SharedWorker.idl
patching file Source/WebCore/workers/Worker.idl

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11518021
Comment 3 Kentaro Hara 2012-02-14 16:48:52 PST
Created attachment 127080 [details]
rebased patch for commit
Comment 4 WebKit Review Bot 2012-02-14 18:05:38 PST
Comment on attachment 127080 [details]
rebased patch for commit

Clearing flags on attachment: 127080

Committed r107768: <http://trac.webkit.org/changeset/107768>