RESOLVED FIXED Bug 78454
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Summary [chromium] Rebaseline JPEG image results after r107389
noel gordon
Reported 2012-02-12 20:47:38 PST
Rebaseline JPEG image results after r107389
Attachments
Patch (494.20 KB, patch)
2012-02-12 21:43 PST, noel gordon
no flags
Patch (12.63 KB, patch)
2012-02-12 23:07 PST, noel gordon
no flags
Patch (1.33 MB, patch)
2012-02-13 12:10 PST, noel gordon
no flags
Patch (1.43 MB, patch)
2012-02-13 22:37 PST, noel gordon
no flags
Patch #4 (214.36 KB, patch)
2012-02-13 23:12 PST, noel gordon
no flags
Patch #6 (1.38 MB, patch)
2012-02-13 23:54 PST, noel gordon
no flags
Patch #7 (1.64 MB, patch)
2012-02-14 00:39 PST, noel gordon
no flags
Patch #8 (170.18 KB, patch)
2012-02-14 15:33 PST, noel gordon
no flags
Patch #9 (1.39 MB, patch)
2012-02-14 17:56 PST, noel gordon
no flags
Patch #10 (1.62 MB, patch)
2012-02-14 19:51 PST, noel gordon
no flags
Patch #11 (728.77 KB, patch)
2012-02-14 23:25 PST, noel gordon
no flags
Patch #12 obsolete (1.65 MB, text/plain)
2012-02-15 02:31 PST, noel gordon
webkit.review.bot: commit-queue-
Patch #13 (1.43 MB, patch)
2012-02-15 04:21 PST, noel gordon
no flags
Patch #15 (1.45 MB, patch)
2012-02-15 15:12 PST, noel gordon
no flags
Patch #20 (1.58 MB, patch)
2012-02-16 00:59 PST, noel gordon
no flags
Patch #21 (1020.39 KB, patch)
2012-02-16 04:31 PST, noel gordon
no flags
Patch #22 (329.69 KB, patch)
2012-02-16 16:02 PST, noel gordon
no flags
Patch #23 (279.61 KB, patch)
2012-02-16 16:17 PST, noel gordon
no flags
Patch #24 (349.17 KB, patch)
2012-02-16 16:54 PST, noel gordon
no flags
Patch #25 (18.57 KB, patch)
2012-02-16 19:50 PST, noel gordon
no flags
Patch #26 (144.50 KB, patch)
2012-02-16 20:17 PST, noel gordon
no flags
Patch #27 (302.16 KB, patch)
2012-02-16 20:34 PST, noel gordon
no flags
Patch #28 obsolete (330.99 KB, text/plain)
2012-02-16 21:14 PST, noel gordon
no flags
Patch #29 (164.90 KB, patch)
2012-02-16 21:26 PST, noel gordon
no flags
Patch #28 (331.06 KB, patch)
2012-02-16 21:38 PST, noel gordon
no flags
Patch #30 (1.93 MB, patch)
2012-02-16 22:55 PST, noel gordon
no flags
Patch #31 (590.53 KB, patch)
2012-02-16 23:16 PST, noel gordon
no flags
Patch #32 obsolete (1.15 MB, text/plain)
2012-02-17 00:17 PST, noel gordon
webkit.review.bot: commit-queue-
Patch #33 (1.65 MB, patch)
2012-02-17 00:54 PST, noel gordon
no flags
Patch #32 (1.15 MB, patch)
2012-02-17 02:12 PST, noel gordon
no flags
Patch #34 (2.12 KB, patch)
2012-02-17 03:25 PST, noel gordon
no flags
noel gordon
Comment 1 2012-02-12 21:43:48 PST
WebKit Review Bot
Comment 2 2012-02-12 22:22:32 PST
Comment on attachment 126711 [details] Patch Attachment 126711 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11510704 New failing tests: compositing/geometry/vertical-scroll-composited.html compositing/geometry/horizontal-scroll-composited.html
noel gordon
Comment 3 2012-02-12 23:07:06 PST
WebKit Review Bot
Comment 4 2012-02-12 23:09:55 PST
Attachment 126720 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/platform/chromium/test_expectations.txt:1249: Path does not exist. fast/css/font-face-descriptor-multiple-values.html [test/expectations] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
noel gordon
Comment 5 2012-02-12 23:38:32 PST
Filed bug 78463 about fast/css/font-face-descriptor-multiple-values.html
WebKit Review Bot
Comment 6 2012-02-13 01:31:01 PST
Comment on attachment 126720 [details] Patch Clearing flags on attachment: 126720 Committed r107545: <http://trac.webkit.org/changeset/107545>
WebKit Review Bot
Comment 7 2012-02-13 01:31:06 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 8 2012-02-13 12:10:31 PST
Reopening to attach new patch.
noel gordon
Comment 9 2012-02-13 12:10:54 PST
noel gordon
Comment 10 2012-02-13 21:29:33 PST
Comment on attachment 126801 [details] Patch Clearing flags on attachment: 126801 Committed r107668: <http://trac.webkit.org/changeset/107668>
noel gordon
Comment 11 2012-02-13 21:29:48 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 12 2012-02-13 22:26:33 PST
noel gordon
Comment 13 2012-02-13 22:37:15 PST
Reopening to attach new patch.
noel gordon
Comment 14 2012-02-13 22:37:23 PST
noel gordon
Comment 15 2012-02-13 22:43:11 PST
Comment on attachment 126908 [details] Patch Clearing flags on attachment: 126908 Committed r107671: <http://trac.webkit.org/changeset/107671>
noel gordon
Comment 16 2012-02-13 22:43:38 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 17 2012-02-13 23:12:30 PST
Reopening to attach new patch.
noel gordon
Comment 18 2012-02-13 23:12:36 PST
Created attachment 126913 [details] Patch #4
noel gordon
Comment 19 2012-02-13 23:22:53 PST
Comment on attachment 126913 [details] Patch #4 Clearing flags on attachment: 126913 Committed r107673: <http://trac.webkit.org/changeset/107673>
noel gordon
Comment 20 2012-02-13 23:23:12 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 21 2012-02-13 23:37:01 PST
Reopening to attach new patch.
noel gordon
Comment 22 2012-02-13 23:39:21 PST
noel gordon
Comment 23 2012-02-13 23:53:56 PST
Reopening to attach new patch.
noel gordon
Comment 24 2012-02-13 23:54:04 PST
Created attachment 126919 [details] Patch #6
noel gordon
Comment 25 2012-02-14 00:18:50 PST
Comment on attachment 126919 [details] Patch #6 Clearing flags on attachment: 126919 Committed r107680: <http://trac.webkit.org/changeset/107680>
noel gordon
Comment 26 2012-02-14 00:19:15 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 27 2012-02-14 00:39:00 PST
Reopening to attach new patch.
noel gordon
Comment 28 2012-02-14 00:39:08 PST
Created attachment 126925 [details] Patch #7
WebKit Review Bot
Comment 29 2012-02-14 03:33:55 PST
The commit-queue encountered the following flaky tests while processing attachment 126925 [details]: perf/object-keys.html bug 63769 (author: ojan@chromium.org) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 30 2012-02-14 03:38:43 PST
Comment on attachment 126925 [details] Patch #7 Clearing flags on attachment: 126925 Committed r107701: <http://trac.webkit.org/changeset/107701>
WebKit Review Bot
Comment 31 2012-02-14 03:38:56 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 32 2012-02-14 15:33:32 PST
Reopening to attach new patch.
noel gordon
Comment 33 2012-02-14 15:33:40 PST
Created attachment 127060 [details] Patch #8
WebKit Review Bot
Comment 34 2012-02-14 17:17:12 PST
Comment on attachment 127060 [details] Patch #8 Clearing flags on attachment: 127060 Committed r107759: <http://trac.webkit.org/changeset/107759>
WebKit Review Bot
Comment 35 2012-02-14 17:17:25 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 36 2012-02-14 17:56:20 PST
Reopening to attach new patch.
noel gordon
Comment 37 2012-02-14 17:56:32 PST
Created attachment 127093 [details] Patch #9
noel gordon
Comment 38 2012-02-14 18:05:49 PST
Comment on attachment 127093 [details] Patch #9 Clearing flags on attachment: 127093 Committed r107767: <http://trac.webkit.org/changeset/107767>
noel gordon
Comment 39 2012-02-14 18:06:24 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 40 2012-02-14 19:36:58 PST
Reopening to attach new patch.
noel gordon
Comment 41 2012-02-14 19:38:03 PST
Patch #10 too big, landing manually.
noel gordon
Comment 42 2012-02-14 19:47:41 PST
Or make #10 smaller.
noel gordon
Comment 43 2012-02-14 19:51:17 PST
Created attachment 127104 [details] Patch #10
noel gordon
Comment 44 2012-02-14 21:11:22 PST
Comment on attachment 127104 [details] Patch #10 Clearing flags on attachment: 127104 Committed r107777: <http://trac.webkit.org/changeset/107777>
noel gordon
Comment 45 2012-02-14 21:12:00 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 46 2012-02-14 23:25:14 PST
Reopening to attach new patch.
noel gordon
Comment 47 2012-02-14 23:25:20 PST
Created attachment 127121 [details] Patch #11
WebKit Review Bot
Comment 48 2012-02-15 00:05:10 PST
Comment on attachment 127121 [details] Patch #11 Clearing flags on attachment: 127121 Committed r107785: <http://trac.webkit.org/changeset/107785>
WebKit Review Bot
Comment 49 2012-02-15 00:05:28 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 50 2012-02-15 02:30:43 PST
Reopening to attach new patch.
noel gordon
Comment 51 2012-02-15 02:31:23 PST
Created attachment 127142 [details] Patch #12 obsolete
WebKit Review Bot
Comment 52 2012-02-15 03:19:24 PST
Comment on attachment 127142 [details] Patch #12 obsolete Rejecting attachment 127142 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ' rm 'LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png' patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 107. Hunk #2 succeeded at 3892 (offset -61 lines). 1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11515697
noel gordon
Comment 53 2012-02-15 03:35:27 PST
Patch #12, zimmerman took these on bug 78219 svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-attr.html svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html
noel gordon
Comment 54 2012-02-15 03:41:42 PST
Marked patch #12 obsolete.
WebKit Review Bot
Comment 55 2012-02-15 04:10:48 PST
Attachment 127142 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource Index mismatch: 0dfd183742a71cb5de5dadc3ae177fc72b63a194 != 9cdcda984def14b8bf8a32b6da6784c8a6ef7b3a rereading 8567f8d3c2539a28a496edaf1048483e973975c2 M LayoutTests/fast/forms/radio-nested-labels.html M LayoutTests/ChangeLog 107798 = 3671b2d23de7ade4cb1d1e78a3f6f7673db6a6c9 already exists! Why are we refetching it? at /usr/lib/git-core/git-svn line 5210 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style.
noel gordon
Comment 56 2012-02-15 04:21:13 PST
Created attachment 127158 [details] Patch #13
WebKit Review Bot
Comment 57 2012-02-15 06:00:56 PST
Comment on attachment 127158 [details] Patch #13 Clearing flags on attachment: 127158 Committed r107807: <http://trac.webkit.org/changeset/107807>
WebKit Review Bot
Comment 58 2012-02-15 06:01:19 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 59 2012-02-15 15:11:32 PST
Reopening to attach new patch.
noel gordon
Comment 60 2012-02-15 15:12:01 PST
Created attachment 127248 [details] Patch #15
WebKit Review Bot
Comment 61 2012-02-15 19:54:41 PST
Comment on attachment 127248 [details] Patch #15 Clearing flags on attachment: 127248 Committed r107876: <http://trac.webkit.org/changeset/107876>
WebKit Review Bot
Comment 62 2012-02-15 19:55:06 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 63 2012-02-16 00:02:10 PST
noel gordon
Comment 64 2012-02-16 00:14:17 PST
noel gordon
Comment 65 2012-02-16 00:23:00 PST
noel gordon
Comment 66 2012-02-16 00:32:01 PST
noel gordon
Comment 67 2012-02-16 00:51:17 PST
noel gordon
Comment 68 2012-02-16 00:59:20 PST
Reopening to attach new patch.
noel gordon
Comment 69 2012-02-16 00:59:32 PST
Created attachment 127326 [details] Patch #20
noel gordon
Comment 70 2012-02-16 01:16:20 PST
noel gordon
Comment 71 2012-02-16 04:31:38 PST
Created attachment 127356 [details] Patch #21
WebKit Review Bot
Comment 72 2012-02-16 05:48:55 PST
Comment on attachment 127356 [details] Patch #21 Clearing flags on attachment: 127356 Committed r107927: <http://trac.webkit.org/changeset/107927>
WebKit Review Bot
Comment 73 2012-02-16 05:49:51 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 74 2012-02-16 16:02:50 PST
Reopening to attach new patch.
noel gordon
Comment 75 2012-02-16 16:02:59 PST
Created attachment 127461 [details] Patch #22
noel gordon
Comment 76 2012-02-16 16:17:24 PST
Created attachment 127463 [details] Patch #23
noel gordon
Comment 77 2012-02-16 16:54:19 PST
Created attachment 127471 [details] Patch #24
WebKit Review Bot
Comment 78 2012-02-16 18:15:50 PST
Comment on attachment 127461 [details] Patch #22 Clearing flags on attachment: 127461 Committed r108012: <http://trac.webkit.org/changeset/108012>
WebKit Review Bot
Comment 79 2012-02-16 18:16:19 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 80 2012-02-16 18:20:19 PST
Reopen for next patch #23
WebKit Review Bot
Comment 81 2012-02-16 18:41:31 PST
Comment on attachment 127463 [details] Patch #23 Clearing flags on attachment: 127463 Committed r108014: <http://trac.webkit.org/changeset/108014>
WebKit Review Bot
Comment 82 2012-02-16 18:42:01 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 83 2012-02-16 18:42:50 PST
Reopen for next patch #24
WebKit Review Bot
Comment 84 2012-02-16 19:28:44 PST
Comment on attachment 127471 [details] Patch #24 Clearing flags on attachment: 127471 Committed r108016: <http://trac.webkit.org/changeset/108016>
WebKit Review Bot
Comment 85 2012-02-16 19:29:13 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 86 2012-02-16 19:50:01 PST
Reopening to attach new patch.
noel gordon
Comment 87 2012-02-16 19:50:08 PST
Created attachment 127501 [details] Patch #25
noel gordon
Comment 88 2012-02-16 20:17:35 PST
Created attachment 127503 [details] Patch #26
noel gordon
Comment 89 2012-02-16 20:34:01 PST
Created attachment 127509 [details] Patch #27
noel gordon
Comment 90 2012-02-16 20:52:26 PST
Comment on attachment 127509 [details] Patch #27 Clearing flags on attachment: 127509 Committed r108024: <http://trac.webkit.org/changeset/108024>
noel gordon
Comment 91 2012-02-16 21:14:50 PST
Created attachment 127513 [details] Patch #28 obsolete
noel gordon
Comment 92 2012-02-16 21:26:59 PST
Created attachment 127515 [details] Patch #29
WebKit Review Bot
Comment 93 2012-02-16 21:27:03 PST
Comment on attachment 127501 [details] Patch #25 Clearing flags on attachment: 127501 Committed r108026: <http://trac.webkit.org/changeset/108026>
WebKit Review Bot
Comment 94 2012-02-16 21:27:33 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 95 2012-02-16 21:30:24 PST
Reopen for patch #26
noel gordon
Comment 96 2012-02-16 21:38:45 PST
Created attachment 127516 [details] Patch #28
WebKit Review Bot
Comment 97 2012-02-16 21:51:28 PST
Comment on attachment 127503 [details] Patch #26 Clearing flags on attachment: 127503 Committed r108030: <http://trac.webkit.org/changeset/108030>
WebKit Review Bot
Comment 98 2012-02-16 21:52:09 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 99 2012-02-16 22:01:11 PST
Reopen for patch #29
WebKit Review Bot
Comment 100 2012-02-16 22:21:49 PST
Comment on attachment 127515 [details] Patch #29 Clearing flags on attachment: 127515 Committed r108033: <http://trac.webkit.org/changeset/108033>
WebKit Review Bot
Comment 101 2012-02-16 22:22:20 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 102 2012-02-16 22:27:01 PST
Reopen for patch #30
noel gordon
Comment 103 2012-02-16 22:55:34 PST
Created attachment 127528 [details] Patch #30
noel gordon
Comment 104 2012-02-16 23:16:46 PST
Created attachment 127531 [details] Patch #31
WebKit Review Bot
Comment 105 2012-02-17 00:08:05 PST
Comment on attachment 127528 [details] Patch #30 Clearing flags on attachment: 127528 Committed r108045: <http://trac.webkit.org/changeset/108045>
WebKit Review Bot
Comment 106 2012-02-17 00:08:44 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 107 2012-02-17 00:11:04 PST
Reopen for patch #31
noel gordon
Comment 108 2012-02-17 00:17:25 PST
Created attachment 127542 [details] Patch #32 obsolete
WebKit Review Bot
Comment 109 2012-02-17 00:37:19 PST
Comment on attachment 127542 [details] Patch #32 obsolete Rejecting attachment 127542 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 10 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 2573. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11543085
noel gordon
Comment 110 2012-02-17 00:43:27 PST
Need more fuzz for #32, will fix shortly.
WebKit Review Bot
Comment 111 2012-02-17 00:45:10 PST
Comment on attachment 127531 [details] Patch #31 Clearing flags on attachment: 127531 Committed r108048: <http://trac.webkit.org/changeset/108048>
WebKit Review Bot
Comment 112 2012-02-17 00:45:52 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 113 2012-02-17 00:53:47 PST
Reopening to attach new patch.
noel gordon
Comment 114 2012-02-17 00:54:06 PST
Created attachment 127547 [details] Patch #33
WebKit Review Bot
Comment 115 2012-02-17 01:48:14 PST
Comment on attachment 127547 [details] Patch #33 Clearing flags on attachment: 127547 Committed r108052: <http://trac.webkit.org/changeset/108052>
WebKit Review Bot
Comment 116 2012-02-17 01:48:53 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 117 2012-02-17 01:58:44 PST
Reopen to re-fuzz patch #32
noel gordon
Comment 118 2012-02-17 02:12:13 PST
Reopening to attach new patch.
noel gordon
Comment 119 2012-02-17 02:12:32 PST
Created attachment 127556 [details] Patch #32
WebKit Review Bot
Comment 120 2012-02-17 03:12:42 PST
Comment on attachment 127556 [details] Patch #32 Clearing flags on attachment: 127556 Committed r108057: <http://trac.webkit.org/changeset/108057>
WebKit Review Bot
Comment 121 2012-02-17 03:13:21 PST
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 122 2012-02-17 03:25:30 PST
Reopening to attach new patch.
noel gordon
Comment 123 2012-02-17 03:25:36 PST
Created attachment 127567 [details] Patch #34
WebKit Review Bot
Comment 124 2012-02-17 04:23:22 PST
Comment on attachment 127567 [details] Patch #34 Clearing flags on attachment: 127567 Committed r108060: <http://trac.webkit.org/changeset/108060>
WebKit Review Bot
Comment 125 2012-02-17 04:24:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.