Bug 78100 - Remove [ConvertToString] from CodeGeneratorCPP.pm and rename it to [ObjCImplementedAsUnsignedLong]
Summary: Remove [ConvertToString] from CodeGeneratorCPP.pm and rename it to [ObjCImple...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 77393
  Show dependency treegraph
 
Reported: 2012-02-08 03:54 PST by Kentaro Hara
Modified: 2012-02-08 16:21 PST (History)
8 users (show)

See Also:


Attachments
Patch (4.77 KB, patch)
2012-02-08 04:00 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-08 03:54:40 PST
Now [ConvertToString] is used in ObjC's HTMLElement.size only. We can remove [ConvertToString] code from CodeGeneratorCPP.pm, and rename [ConvertToString] to [ObjCImplementedAsUnsignedLong].
Comment 1 Kentaro Hara 2012-02-08 04:00:20 PST
Created attachment 126048 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-08 15:34:08 PST
Comment on attachment 126048 [details]
Patch

Amazing.
Comment 3 WebKit Review Bot 2012-02-08 16:21:35 PST
Comment on attachment 126048 [details]
Patch

Clearing flags on attachment: 126048

Committed r107148: <http://trac.webkit.org/changeset/107148>
Comment 4 WebKit Review Bot 2012-02-08 16:21:43 PST
All reviewed patches have been landed.  Closing bug.