Bug 77460 - Remove CSSStyleDeclaration isElementStyleDeclaration bit
Summary: Remove CSSStyleDeclaration isElementStyleDeclaration bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 77745
  Show dependency treegraph
 
Reported: 2012-01-31 11:18 PST by Antti Koivisto
Modified: 2012-02-03 09:42 PST (History)
1 user (show)

See Also:


Attachments
patch (8.46 KB, patch)
2012-01-31 11:23 PST, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-01-31 11:18:15 PST
Only style declarations with element parent are now inline style declarations. We can remove the bit and the associated logic.
Comment 1 Antti Koivisto 2012-01-31 11:23:06 PST
Created attachment 124782 [details]
patch
Comment 2 WebKit Review Bot 2012-01-31 11:24:56 PST
Attachment 124782 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: Fix compilation errors on build-webkit --debug --no-workers on mac.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging LayoutTests/platform/qt/Skipped
CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2012-01-31 11:29:36 PST
Comment on attachment 124782 [details]
patch

Me gusta.
Comment 4 Antti Koivisto 2012-02-03 09:42:18 PST
http://trac.webkit.org/changeset/106384