Bug 77442 - [Qt] PlatformTouchPoint does not set radius and force values
Summary: [Qt] PlatformTouchPoint does not set radius and force values
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
Depends on:
Reported: 2012-01-31 08:49 PST by Allan Sandfeld Jensen
Modified: 2012-02-01 09:39 PST (History)
1 user (show)

See Also:

Patch (2.64 KB, patch)
2012-01-31 08:54 PST, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-01-31 08:49:47 PST
The constructor in PlatformTouchPointQt does not set all the values that are possible.

We can not currently get a rotationAngle value from the Qt api, but radius and force is can be set from touch.rect and touch.pressure values.

These values are currently only used by WebCore to pass on to Web application using the DOM Touch API.
Comment 1 Allan Sandfeld Jensen 2012-01-31 08:54:32 PST
Created attachment 124748 [details]
Comment 2 WebKit Review Bot 2012-01-31 08:59:09 PST
Attachment 124748 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: Fix compilation errors on build-webkit --debug --no-workers on mac.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging LayoutTests/platform/qt/Skipped
CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2012-02-01 09:39:14 PST
Comment on attachment 124748 [details]

Clearing flags on attachment: 124748

Committed r106470: <http://trac.webkit.org/changeset/106470>
Comment 4 WebKit Review Bot 2012-02-01 09:39:18 PST
All reviewed patches have been landed.  Closing bug.