Bug 77435 - [Chromium] Make sure that viewport computations are based on the latest framerect size.
Summary: [Chromium] Make sure that viewport computations are based on the latest frame...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fady Samuel
URL:
Keywords:
Depends on:
Blocks: 70559
  Show dependency tree / graph
 
Reported: 2012-01-31 07:11 PST by Fady Samuel
Modified: 2012-03-08 11:55 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.86 KB, patch)
2012-01-31 07:12 PST, Fady Samuel 		fishd: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fady Samuel 2012-01-31 07:11:20 PST 
[Chromium] Make sure that viewport computations are based on the latest framerect size.
Comment 1 Fady Samuel 2012-01-31 07:12:23 PST 
Created attachment 124726 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-31 07:15:24 PST 
Attachment 124726 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
From git://git.webkit.org/WebKit
   f5e58c7..2366cac  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 106358 = f5e58c7fca5f55729d43f04848daca0e72ec5075
r106359 = 2366cac6c66ce637903152f5fc58cd98b5686950
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Applying: Fix compilation errors on build-webkit --debug --no-workers on mac.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging LayoutTests/platform/qt/Skipped
CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Fisher (:fishd, Google) 2012-01-31 13:02:37 PST 
Comment on attachment 124726 [details]
Patch

Is there a way to write a regression test for this?
Comment 4 Fady Samuel 2012-03-08 11:55:57 PST 
New patch by aelias makes this unnecessary.