CSSElementStyleDeclaration has little functionality. It can merge with CSSMutableStyleDeclaration simplifying the code.
Created attachment 123600 [details] patch
Attachment 123600 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/css/CSSMutableStyleDeclaration.h:150: The parameter name "element" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 123600 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=123600&action=review r=me > Source/WebCore/css/CSSStyleRule.cpp:-108 > - if (!doc && m_style->isElementStyleDeclaration()) { > - if (StyledElement* element = static_cast<CSSElementStyleDeclaration*>(m_style.get())->element()) > - doc = element->document(); > - } Oh dear. Who put this crap here? :(
http://trac.webkit.org/changeset/105642