Bug 76636 - Web Inspector: Switching tabs in TabbedEditorContainer should reveal selected script in navigator.
Summary: Web Inspector: Switching tabs in TabbedEditorContainer should reveal selected...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-19 07:51 PST by Vsevolod Vlasov
Modified: 2012-01-19 10:57 PST (History)
10 users (show)

See Also:

Attachments
Patch (10.39 KB, patch)
2012-01-19 07:57 PST, Vsevolod Vlasov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-01-19 07:51:06 PST 
Switching tabs in TabbedEditorContainer should reveal selected script in navigator.
Comment 1 Vsevolod Vlasov 2012-01-19 07:57:14 PST 
Created attachment 123130 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-01-19 07:57:28 PST 
- Renamed FileSelector's ScriptSelected event into FileSelected, added EditorSelected event to EditorContainer.
- Renamed _showSourceFrame into _showFile.
- Made _uiSourceCodeRemoved reuse _removeSourceFrame.
Comment 3 Alexander Pavlov (apavlov) 2012-01-19 09:31:05 PST 
Comment on attachment 123130 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123130&action=review

> Source/WebCore/inspector/front-end/ScriptsPanel.js:92
> +    this._editorContainer.addEventListener(WebInspector.ScriptsPanel.EditorContainer.Events.EditorSelected, this._editorSelected, this);

EditorActivated? Seems like selection assumes subsequent manipulation on the selected object (move, rename, delete, etc.)
Comment 4 Vsevolod Vlasov 2012-01-19 10:57:19 PST 
Committed r105427: <http://trac.webkit.org/changeset/105427>