Bug 76030 - ShouldSkipTypeHeader() and ShouldSkipTypeInImplementation() in CodeGeneratorCPP.pm should be the same
Summary: ShouldSkipTypeHeader() and ShouldSkipTypeInImplementation() in CodeGeneratorC...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 72138
  Show dependency treegraph
Reported: 2012-01-10 22:53 PST by Kentaro Hara
Modified: 2012-01-11 02:25 PST (History)
4 users (show)

See Also:

Patch (6.54 KB, patch)
2012-01-10 23:25 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-01-10 22:53:22 PST
The conditions under which 1 is returned by ShouldSkipTypeHeader() and ShouldSkipTypeInImplementation() are messy. We should clean up the conditions.

This is a refactoring for implementing the [Supplemental] IDL for custom methods.
Comment 1 Kentaro Hara 2012-01-10 23:25:58 PST
Created attachment 121982 [details]
Comment 2 WebKit Review Bot 2012-01-11 02:25:09 PST
Comment on attachment 121982 [details]

Clearing flags on attachment: 121982

Committed r104690: <http://trac.webkit.org/changeset/104690>
Comment 3 WebKit Review Bot 2012-01-11 02:25:19 PST
All reviewed patches have been landed.  Closing bug.