RESOLVED FIXED75739
[Qt][WK2] Add font-related API tests for QWebPreferences 
https://bugs.webkit.org/show_bug.cgi?id=75739
Summary [Qt][WK2] Add font-related API tests for QWebPreferences
Rafael Brandao
Reported 2012-01-06 13:50:04 PST
[Qt][WK2] Add font-related API tests for QWebPreferences
Attachments
Patch (13.53 KB, patch)
2012-01-06 13:54 PST, Rafael Brandao 		no flags
DetailsFormatted DiffDiff
Patch (13.55 KB, patch)
2012-01-10 05:13 PST, Rafael Brandao 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rafael Brandao
Comment 1 2012-01-06 13:54:35 PST
Created attachment 121489 [details] Patch
Rafael Brandao
Comment 2 2012-01-06 14:06:40 PST
(In reply to comment #1) > Created an attachment (id=121489) [details] > Patch There was a bit of problem to test changes on font family preferences when it is about generic fonts, because the chosen font is not reported back to the DOM. So if we use "monospace" there, and then set "foobar" as the font for the generic name "monospace", when we request the font to DOM, we still get the generic name. :-( So for those I've just added basic test coverage, as we had none up until now.
Rafael Brandao
Comment 3 2012-01-10 05:13:32 PST
Created attachment 121831 [details] Patch
Zoltan Herczeg
Comment 4 2012-01-10 05:52:59 PST
Comment on attachment 121831 [details] Patch r=me
WebKit Review Bot
Comment 5 2012-01-10 07:14:20 PST
Comment on attachment 121831 [details] Patch Clearing flags on attachment: 121831 Committed r104567: <http://trac.webkit.org/changeset/104567>
WebKit Review Bot
Comment 6 2012-01-10 07:14:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.