Bug 75573 - [chromium] Make it safe to delete WorkerFileSystemContextObserver on any thread.
Summary: [chromium] Make it safe to delete WorkerFileSystemContextObserver on any thread.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks: 74666
  Show dependency tree / graph
 
Reported: 2012-01-04 14:05 PST by David Levin
Modified: 2012-01-04 19:11 PST (History)
4 users (show)

See Also:

Attachments
Patch (8.88 KB, patch)
2012-01-04 14:23 PST, David Levin 		no flags Details | Formatted Diff | Diff
Patch (9.61 KB, patch)
2012-01-04 14:27 PST, David Levin 		no flags Details | Formatted Diff | Diff
Patch (9.70 KB, patch)
2012-01-04 14:28 PST, David Levin 		dimich: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2012-01-04 14:05:29 PST 
See summary.
Comment 1 David Levin 2012-01-04 14:23:12 PST 
Created attachment 121154 [details]
Patch
Comment 2 David Levin 2012-01-04 14:27:16 PST 
Created attachment 121155 [details]
Patch
Comment 3 David Levin 2012-01-04 14:28:27 PST 
Created attachment 121156 [details]
Patch
Comment 4 Dmitry Titov 2012-01-04 14:40:59 PST 
Comment on attachment 121156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121156&action=review

Nice, one comment:

> Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp:170
> +    // so WorkerFileSystemCallbacksBridge will be valid while this class is around.

Need to fix comment as discussed offline.
Comment 5 David Levin 2012-01-04 19:11:18 PST 
Committed as http://trac.webkit.org/changeset/104111