Bug 75488 - [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
Summary: [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexander Færøy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-03 13:25 PST by Alexander Færøy
Modified: 2012-01-04 06:05 PST (History)
2 users (show)

See Also:

Attachments
Patch (7.18 KB, patch)
2012-01-03 13:34 PST, Alexander Færøy 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Færøy 2012-01-03 13:25:21 PST 
SSIA.
Comment 1 Alexander Færøy 2012-01-03 13:34:09 PST 
Created attachment 120986 [details]
Patch
Comment 2 Alexander Færøy 2012-01-03 13:35:01 PST 
Adding Tor Arne.
Comment 3 Tor Arne Vestbø 2012-01-04 04:22:08 PST 
Comment on attachment 120986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120986&action=review

> Tools/MiniBrowser/qt/qml/PromptDialog.qml:40
> +        width: dialog.width - 30

For the furture, this is better done with an anchor and a margin.
Comment 4 Alexander Færøy 2012-01-04 04:48:50 PST 
Comment on attachment 120986 [details]
Patch

Requesting CQ :)
Comment 5 WebKit Review Bot 2012-01-04 06:05:08 PST 
Comment on attachment 120986 [details]
Patch

Clearing flags on attachment: 120986

Committed r104032: <http://trac.webkit.org/changeset/104032>
Comment 6 WebKit Review Bot 2012-01-04 06:05:12 PST 
All reviewed patches have been landed.  Closing bug.