RESOLVED FIXED 74773
Move everyone off of WorkItem 
https://bugs.webkit.org/show_bug.cgi?id=74773
Summary Move everyone off of WorkItem
Anders Carlsson
Reported 2011-12-16 17:39:48 PST
Move everyone off of WorkItem
Attachments
Patch (32.01 KB, patch)
2011-12-16 17:41 PST, Anders Carlsson 		darin: review+
gustavo: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-12-16 17:41:54 PST
Created attachment 119706 [details] Patch
Darin Adler
Comment 2 2011-12-16 22:47:19 PST
Windows build failure: 9>..\Platform\win\WorkQueueWin.cpp(40) : error C2065: 'fuction' : undeclared identifier 9>..\Platform\win\WorkQueueWin.cpp(152) : error C2039: 'item' : is not a member of 'WorkQueue::WorkItemWin' 9> c:\cygwin\home\buildbot\WebKit\Source\WebKit2\Platform\WorkQueue.h(118) : see declaration of 'WorkQueue::WorkItemWin' 9>..\Platform\win\WorkQueueWin.cpp(152) : error C2227: left of '->execute' must point to class/struct/union/generic type 9>..\Platform\win\WorkQueueWin.cpp(197) : error C2059: syntax error : ')'
Darin Adler
Comment 3 2011-12-16 22:47:47 PST
Comment on attachment 119706 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119706&action=review > Source/WebKit2/Platform/win/WorkQueueWin.cpp:40 > + return adoptRef(new WorkItemWin(fuction, queue)); Typo here: “fuction”.
Gustavo Noronha (kov)
Comment 4 2011-12-17 01:17:26 PST
Comment on attachment 119706 [details] Patch Attachment 119706 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10928042
Anders Carlsson
Comment 5 2011-12-18 09:07:02 PST
Committed r103178: <http://trac.webkit.org/changeset/103178>
Note You need to log in before you can comment on or make changes to this bug.