Bug 74574 - Add WorkQueue::dispatch and RunLoop::dispatch which both take WTF::Function objects
Summary: Add WorkQueue::dispatch and RunLoop::dispatch which both take WTF::Function o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-14 18:01 PST by Anders Carlsson
Modified: 2011-12-15 15:37 PST (History)
2 users (show)

See Also:

Attachments
Patch (10.39 KB, patch)
2011-12-14 18:03 PST, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-12-14 18:01:42 PST 
Add WorkQueue::dispatch and RunLoop::dispatch which both take WTF::Function objects
Comment 1 Anders Carlsson 2011-12-14 18:03:30 PST 
Created attachment 119354 [details]
Patch
Comment 2 WebKit Review Bot 2011-12-14 18:07:47 PST 
Attachment 119354 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/Platform/RunLoop.h:51:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebKit2/Platform/WorkQueue.h:56:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2011-12-14 18:11:03 PST 
Committed r102866: <http://trac.webkit.org/changeset/102866>
Comment 4 Brady Eidson 2011-12-15 15:37:40 PST 
This caused a repro crasher: https://bugs.webkit.org/show_bug.cgi?id=74655