Bug 74398 - HTML details summary not working with form controls
Summary: HTML details summary not working with form controls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-13 04:02 PST by Hajime Morrita
Modified: 2011-12-13 20:59 PST (History)
2 users (show)

See Also:


Attachments
Patch (4.77 KB, patch)
2011-12-13 04:07 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (4.71 KB, patch)
2011-12-13 18:05 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2011-12-13 04:02:32 PST
From http://code.google.com/p/chromium/issues/detail?id=106834
Comment 1 Hajime Morrita 2011-12-13 04:07:39 PST
Created attachment 118999 [details]
Patch
Comment 2 Hajime Morrita 2011-12-13 04:08:21 PST
Hi Kent-san, Could you take a look?
Comment 3 Kent Tamura 2011-12-13 17:04:07 PST
Comment on attachment 118999 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118999&action=review

> LayoutTests/fast/html/details-click-controls-expected.txt:1
> +ALERT: [object HTMLInputElement]

Do you need this ALERT message?
Comment 4 Hajime Morrita 2011-12-13 18:05:22 PST
Created attachment 119127 [details]
Patch
Comment 5 Hajime Morrita 2011-12-13 18:05:59 PST
> Do you need this ALERT message?
No! Thanks for the catch. I updated the patch.
Comment 6 Kent Tamura 2011-12-13 18:20:59 PST
Comment on attachment 119127 [details]
Patch

Looks ok.
Comment 7 WebKit Review Bot 2011-12-13 20:59:49 PST
Comment on attachment 119127 [details]
Patch

Clearing flags on attachment: 119127

Committed r102734: <http://trac.webkit.org/changeset/102734>
Comment 8 WebKit Review Bot 2011-12-13 20:59:53 PST
All reviewed patches have been landed.  Closing bug.