Bug 74334 - Enable CSS_FILTERS in Chromium
Summary: Enable CSS_FILTERS in Chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-12 14:24 PST by Stephen White
Modified: 2011-12-16 05:05 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.02 KB, patch)
2011-12-12 14:28 PST, Stephen White 		no flags Details | Formatted Diff | Diff
Patch (2.45 KB, patch)
2011-12-15 13:57 PST, Stephen White 		no flags Details | Formatted Diff | Diff
Patch (2.31 KB, patch)
2011-12-15 14:29 PST, Stephen White 		cmarrin: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2011-12-12 14:24:55 PST 
The CSS_FILTERS feature should be enabled in Chromium.
Comment 1 Stephen White 2011-12-12 14:28:06 PST 
Created attachment 118848 [details]
Patch
Comment 2 Stephen White 2011-12-13 10:17:12 PST 
Ken, mind taking a look?
Comment 3 Kenneth Russell 2011-12-13 10:19:06 PST 
Comment on attachment 118848 [details]
Patch

Looks fine to me.
Comment 4 WebKit Review Bot 2011-12-13 11:44:08 PST 
Comment on attachment 118848 [details]
Patch

Clearing flags on attachment: 118848

Committed r102693: <http://trac.webkit.org/changeset/102693>
Comment 5 WebKit Review Bot 2011-12-13 11:44:13 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Kenneth Russell 2011-12-13 13:43:01 PST 
Reverted r102693 for reason:

Broke Chromium Windows DRT build

Committed r102703: <http://trac.webkit.org/changeset/102703>
Comment 7 Stephen White 2011-12-15 07:28:11 PST 
Comment on attachment 118848 [details]
Patch

I'd like to re-land this today.  Ken, please r+ when it's convenient for you, so we can clobber the Win bots.
Comment 8 Stephen White 2011-12-15 10:20:03 PST 
Comment on attachment 118848 [details]
Patch

Clearing flags on attachment: 118848

Committed r102956: <http://trac.webkit.org/changeset/102956>
Comment 9 Stephen White 2011-12-15 10:20:08 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Stephen White 2011-12-15 11:48:13 PST 
Reverted r102956 for reason:

Breaks

Committed r102972: <http://trac.webkit.org/changeset/102972>
Comment 11 Kenneth Russell 2011-12-15 11:57:06 PST 
(In reply to comment #10)
> Breaks

Should read "Breaks Chromium/Win build".
Comment 12 Stephen White 2011-12-15 13:57:12 PST 
Created attachment 119497 [details]
Patch
Comment 13 Stephen White 2011-12-15 14:29:47 PST 
Created attachment 119504 [details]
Patch
Comment 14 Stephen White 2011-12-16 05:05:06 PST 
Committed r103059: <http://trac.webkit.org/changeset/103059>