Bug 74195 - Force a layout before calls to layoutTestController.display()
Summary: Force a layout before calls to layoutTestController.display()
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-09 12:04 PST by Tony Chang
Modified: 2011-12-16 12:18 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-12-09 12:04:48 PST 
I tried to fix a flaky repaint test in Chromium by forcing a layout before a call to layoutTestController.display().

Darin suggested having DRT always call layout before display().  This might work, but we should see if
1) This is already happening on Mac (implicitly or explicitly).
2) Seeing if this regresses any tests on Chromium (it probably won't, but we'd want to verify).

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Freplaced%2Fwidth100percent-textarea.html
Comment 1 Tony Chang 2011-12-09 16:54:04 PST 
This didn't actual work in fixing the test.  Ojan points out that a layout doesn't force a paint, so maybe we need to fix DRT to both layout and paint in lTC.display() before drawing the grey box.
Comment 2 Tony Chang 2011-12-16 12:18:29 PST 
Hmm, it looks like we already do this.  We layout and repaint before drawing the repaint mask.

http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp#L1206

http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp#L1577