Add the FileSystem of iOS
Created attachment 118529 [details] Patch
Comment on attachment 118529 [details] Patch Were the added files published in iOS code drops before? In that case, they may need to retain existing copyright dates.
Comment on attachment 118529 [details] Patch (In reply to comment #2) > (From update of attachment 118529 [details]) > Were the added files published in iOS code drops before? In that case, they may need to retain existing copyright dates. I think one of them was. I will check
Comment on attachment 118529 [details] Patch > I think one of them was. I will check Nope, actually that is fine.
Comment on attachment 118529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118529&action=review r- to address a strategy for Source/WebKit code sharing and platform structure. It may be easier to land the WebCore pieces first. > Source/WebKit/mac/Misc/WebNSFileManagerExtras.h:39 > @interface NSFileManager (WebNSFileManagerExtras) > +#if !PLATFORM(IOS) > - (void)_webkit_setMetadataURL:(NSString *)URLString referrer:(NSString *)referrer atPath:(NSString *)path; > - (NSString *)_webkit_startupVolumeName; > +#endif // !PLATFORM(IOS) > + > +#if PLATFORM(IOS) > +- (NSString *)_webkit_createTemporaryDirectoryWithTemplatePrefix:(NSString *)prefix; > +#endif // PLATFORM(IOS) We need to come up with a better strategy for sharing this code rather than mixing Mac-only, iOS-only and shared methods into a single header and implementation file. Also, adding PLATFORM(IOS) macros won't work for any public headers unless we start post-processing the headers to strip out these macros, and it could impact any Apple projects using private headers as SPI (since these macros won't be defined when they build their projects).
Created attachment 118670 [details] Patch
> We need to come up with a better strategy for sharing this code rather than mixing Mac-only, iOS-only and shared methods into a single header and implementation file. Good point. I believed we could do that afterwards but we can't since that would pollute the public headers.
Comment on attachment 118670 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118670&action=review r=me > Source/WebCore/platform/ios/FileSystemIOS.mm:31 > +#if PLATFORM(IOS) Is this needed with the EXCLUDED_SOURCE_FILE_NAMES variable in Source/WebCore/Configurations/WebCore.xcconfig?
> > Source/WebCore/platform/ios/FileSystemIOS.mm:31 > > +#if PLATFORM(IOS) > > Is this needed with the EXCLUDED_SOURCE_FILE_NAMES variable in Source/WebCore/Configurations/WebCore.xcconfig? Nope, that shouldn't be necessary. I'll update that before landing. Thanks for the review.
Committed r102517: <http://trac.webkit.org/changeset/102517>