Bug 74136 - Avoid reloading storage pointer for indexed properties unnecessarily
Summary: Avoid reloading storage pointer for indexed properties unnecessarily
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-08 16:04 PST by Oliver Hunt
Modified: 2011-12-09 00:46 PST (History)
1 user (show)

See Also:


Attachments
Patch (40.27 KB, patch)
2011-12-08 16:14 PST, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (40.35 KB, patch)
2011-12-08 16:29 PST, Oliver Hunt
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-12-08 16:04:46 PST
Avoid reloading storage pointer for indexed properties unnecessarily
Comment 1 Oliver Hunt 2011-12-08 16:14:41 PST
Created attachment 118485 [details]
Patch
Comment 2 Filip Pizlo 2011-12-08 16:21:54 PST
Comment on attachment 118485 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118485&action=review

> Source/JavaScriptCore/dfg/DFGPropagator.cpp:1257
> +                if (byValIsPure(node))

I think this is wrong. ;-)
Comment 3 Oliver Hunt 2011-12-08 16:29:16 PST
Created attachment 118486 [details]
Patch
Comment 4 WebKit Review Bot 2011-12-09 00:46:05 PST
Comment on attachment 118486 [details]
Patch

Clearing flags on attachment: 118486

Committed r102442: <http://trac.webkit.org/changeset/102442>
Comment 5 WebKit Review Bot 2011-12-09 00:46:09 PST
All reviewed patches have been landed.  Closing bug.