Bug 73608 - Support integer typed arrays in the DFG JIT
Summary: Support integer typed arrays in the DFG JIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-01 17:47 PST by Oliver Hunt
Modified: 2011-12-01 17:57 PST (History)
1 user (show)

See Also:


Attachments
Patch (76.87 KB, patch)
2011-12-01 17:50 PST, Oliver Hunt
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-12-01 17:47:42 PST
Support integer typed arrays in the DFG JIT
Comment 1 Oliver Hunt 2011-12-01 17:50:21 PST
Created attachment 117535 [details]
Patch
Comment 2 WebKit Review Bot 2011-12-01 17:52:25 PST
Attachment 117535 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/assembler/X86Assembler.h:1101:  movw_rm is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/assembler/X86Assembler.h:1440:  cvttsd2siq_rr is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMv7Assembler.h:1669:  vcvt_floatingPointToUnsigned is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 3 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2011-12-01 17:53:48 PST
Comment on attachment 117535 [details]
Patch

r=me
Comment 4 Oliver Hunt 2011-12-01 17:57:14 PST
Committed r101729: <http://trac.webkit.org/changeset/101729>