Bug 73243 - [MutationObservers] Fix build breakage after CSSInlineDeclaration refactor
: [MutationObservers] Fix build breakage after CSSInlineDeclaration refactor
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: HTML DOM
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Rafael Weinstein
:
Depends on:
Blocks: 68729
  Show dependency treegraph
 
Reported: 2011-11-28 13:21 PST by Rafael Weinstein
Modified: 2011-11-28 17:31 PST (History)
7 users (show)

See Also:


Attachments
Patch (2.41 KB, patch)
2011-11-28 13:23 PST, Rafael Weinstein
no flags Details | Formatted Diff | Diff
Patch (3.05 KB, patch)
2011-11-28 13:51 PST, Rafael Weinstein
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Weinstein 2011-11-28 13:21:37 PST
bug 73121 broke code that is behind the MUTATION_OBSERVERS compile flag.
Comment 1 Rafael Weinstein 2011-11-28 13:23:16 PST
Created attachment 116807 [details]
Patch
Comment 2 Ryosuke Niwa 2011-11-28 13:36:08 PST
Comment on attachment 116807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116807&action=review

> Source/WebCore/css/CSSMutableStyleDeclaration.cpp:69
> +        CSSInlineStyleDeclaration* inlineDecl = static_cast<CSSInlineStyleDeclaration*>(s_currentDecl);

We should add toCSSInlineStyleDeclaration.
Comment 3 Rafael Weinstein 2011-11-28 13:51:35 PST
Created attachment 116814 [details]
Patch
Comment 4 Ryosuke Niwa 2011-11-28 13:56:39 PST
Comment on attachment 116814 [details]
Patch

Thanks for adding toCSSInlineStyleDeclaration!
Comment 5 WebKit Review Bot 2011-11-28 17:31:50 PST
Comment on attachment 116814 [details]
Patch

Clearing flags on attachment: 116814

Committed r101310: <http://trac.webkit.org/changeset/101310>
Comment 6 WebKit Review Bot 2011-11-28 17:31:55 PST
All reviewed patches have been landed.  Closing bug.