Following up from Antonio Gomes's comment in bug #72768 (https://bugs.webkit.org/show_bug.cgi?id=72768#c5), we should move the HarfBuzz files from WebCore/platform/graphics/chromium to a HarfBuzz directory since both the Chromium Linux and BlackBerry-port make use of these files. These files include: platform/graphics/chromium/ComplexTextControllerLinux.cpp platform/graphics/chromium/FontCacheLinux.cpp platform/graphics/chromium/FontLinux.cpp platform/graphics/chromium/FontPlatformDataLinux.cpp platform/graphics/chromium/HarfbuzzSkia.cpp platform/graphics/chromium/SimpleFontDataLinux.cpp
SGTM.
Should we change the "Linux" suffix to "HarfBuzz" at the same time?
(In reply to comment #2) > Should we change the "Linux" suffix to "HarfBuzz" at the same time? Sounds reasonable.
Created attachment 120114 [details] Patch
Attachment 120114 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/harfbuzz/HarfBuzzSkia.cpp:47: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 120114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120114&action=review LGTM. FYI, I'm working on Harfbuzz-ng transition on Chromium port (https://bugs.webkit.org/show_bug.cgi?id=67933). It will take time because Harfbuzz-ng have performance and rendering regression as far as I tested. > Source/WebCore/WebCore.gyp/WebCore.gyp:1481 > + ['include', 'platform/graphics/harfbuzz/SimpleFontDataSkia\\.cpp$'], Shouldn't we also add 'harfbuzz' in 'exclude' pattern at line 1396 and 1451?
Created attachment 120605 [details] Patch
Attachment 120605 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/harfbuzz/HarfBuzzSkia.cpp:47: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 120605 [details] Patch Looks sane to me.
Comment on attachment 120605 [details] Patch Attachment 120605 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11040333
Created attachment 120613 [details] Patch for landing
Comment on attachment 120613 [details] Patch for landing Clearing flags on attachment: 120613 Committed r103742: <http://trac.webkit.org/changeset/103742>
All reviewed patches have been landed. Closing bug.