http://build.webkit.org/builders/Lion%20Intel%20Leaks/builds/175 says: 361 total leaks found for a total of 66,992 bytes! 1 unique leaks found! But there are more than 1 unique leaks. Seems like a bug in NRWT.
:( I swear I've seen it say other numbers. Could this have been from your unquoting change earlier today?
(In reply to comment #1) > Could this have been from your unquoting change earlier today? This was happening long before that change: http://build.webkit.org/builders/Lion%20Intel%20Leaks/builds/114 "8676 total leaks found for a total of 1,856,864 bytes! 1 unique leaks found!"
Created attachment 115862 [details] Make NRWT consider all lines of output from parse-malloc-history, not just the first
Attachment 115862 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:133: trailing whitespace [pep8/W291] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 115862 [details] Make NRWT consider all lines of output from parse-malloc-history, not just the first View in context: https://bugs.webkit.org/attachment.cgi?id=115862&action=review >> Tools/Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:133 >> +147 calls for 9,408 bytes: _CFRuntimeCreateInstance | _ZN3WTF24StringWrapperCFAllocatorL8allocateElmPv StringImplCF.cpp:67 | WTF::fastMalloc(unsigned long) FastMalloc.cpp:268 | malloc | malloc_zone_malloc > > trailing whitespace [pep8/W291] [5] Too bad! That's what parse-malloc-history gives us.
Committed r100912: <http://trac.webkit.org/changeset/100912>
Seems to be working: http://build.webkit.org/builders/Lion%20Intel%20Leaks/builds/228/steps/layout-test "1293 total leaks found for a total of 156,416 bytes! 90 unique leaks found! 15 failures 6 flakes 6 missing results"
Thanks adam.