As it says.
Created attachment 115665 [details]
Comment on attachment 115665 [details]
Should we do this in other files where we currently disable the warning for the entire file?
In most cases, yes.
Landed in r100668.
Rolled out in r100703 because apparently our SnowLeopard bots are still using Xcode 3.2.6 and thus are building WebCore with GCC… which is unhappy with some of the "#pragma GCC diagnostic" stuff. I think upgrading the bots to a less ancient version of Xcode may be the best solution. I’ll look in to that tomorrow.
Created attachment 115999 [details]
This switches to using “#pragma diagnostic clang” wrapped in “#if COMPILER(CLANG)” since push / pop don’t work for GCC anyway. The fact it won’t have any effect on GCC doesn’t matter since GCC isn’t a supported compiler for WebKit on anything newer than SnowLeopard.
Landed in r100872.