Bug 72646 - Disable deprecation warnings around code where we cannot easily switch away from the deprecated APIs.
Summary: Disable deprecation warnings around code where we cannot easily switch away f...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
Depends on:
Reported: 2011-11-17 13:13 PST by Mark Rowe (bdash)
Modified: 2011-11-20 14:56 PST (History)
0 users

See Also:

Patch v1 (8.12 KB, patch)
2011-11-17 13:24 PST, Mark Rowe (bdash)
no flags Details | Formatted Diff | Diff
Patch v2 (8.42 KB, patch)
2011-11-20 14:40 PST, Mark Rowe (bdash)
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2011-11-17 13:13:29 PST
As it says.
Comment 1 Mark Rowe (bdash) 2011-11-17 13:24:50 PST
Created attachment 115665 [details]
Patch v1

Comment 2 mitz 2011-11-17 13:36:17 PST
Comment on attachment 115665 [details]
Patch v1

Should we do this in other files where we currently disable the warning for the entire file?
Comment 3 Mark Rowe (bdash) 2011-11-17 13:37:17 PST
In most cases, yes.
Comment 4 Mark Rowe (bdash) 2011-11-17 13:51:43 PST
Landed in r100668.
Comment 5 Mark Rowe (bdash) 2011-11-17 17:19:50 PST
Rolled out in r100703 because apparently our SnowLeopard bots are still using Xcode 3.2.6 and thus are building WebCore with GCC… which is unhappy with some of the "#pragma GCC diagnostic" stuff.  I think upgrading the bots to a less ancient version of Xcode may be the best solution.  I’ll look in to that tomorrow.
Comment 6 Mark Rowe (bdash) 2011-11-20 14:40:50 PST
Created attachment 115999 [details]
Patch v2

This switches to using “#pragma diagnostic clang” wrapped in “#if COMPILER(CLANG)” since push / pop don’t work for GCC anyway. The fact it won’t have any effect on GCC doesn’t matter since GCC isn’t a supported compiler for WebKit on anything newer than SnowLeopard.
Comment 7 Mark Rowe (bdash) 2011-11-20 14:56:29 PST
Landed in r100872.