WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
72295
JS Test Harness: Remove need to load external css file to reduce flakiness
https://bugs.webkit.org/show_bug.cgi?id=72295
Summary
JS Test Harness: Remove need to load external css file to reduce flakiness
Erik Arvidsson
Reported
2011-11-14 12:07:19 PST
JS Test Harness: Use a data url for the stylesheet to reduce flakiness
Attachments
Patch
(2.68 KB, patch)
2011-11-14 12:21 PST
,
Erik Arvidsson
no flags
Details
Formatted Diff
Diff
Patch
(9.13 KB, patch)
2011-11-15 15:03 PST
,
Erik Arvidsson
ojan
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Erik Arvidsson
Comment 1
2011-11-14 12:21:46 PST
Created
attachment 115001
[details]
Patch
Ojan Vafai
Comment 2
2011-11-14 13:48:18 PST
Comment on
attachment 115001
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=115001&action=review
> LayoutTests/ChangeLog:7 > +
Can you add more details here about how this reduces flakiness? Just a couple lines that matches what you told me in person.
> LayoutTests/ChangeLog:9 > + ():
FYI, in the future, you can remove these dummy lines. The prepare-changelog parsing doesn't work very well for JS.
Erik Arvidsson
Comment 3
2011-11-15 15:03:43 PST
Created
attachment 115260
[details]
Patch
Ojan Vafai
Comment 4
2011-11-15 16:02:12 PST
Comment on
attachment 115260
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=115260&action=review
> LayoutTests/ChangeLog:7 > +
Still need a short description of why this reduces flakiness.
Erik Arvidsson
Comment 5
2011-11-15 16:45:58 PST
Committed
r100369
: <
http://trac.webkit.org/changeset/100369
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug