Bug 72295 - JS Test Harness: Remove need to load external css file to reduce flakiness
Summary: JS Test Harness: Remove need to load external css file to reduce flakiness
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-14 12:07 PST by Erik Arvidsson
Modified: 2011-11-15 16:45 PST (History)
1 user (show)

See Also:

Attachments
Patch (2.68 KB, patch)
2011-11-14 12:21 PST, Erik Arvidsson 		no flags Details | Formatted Diff | Diff
Patch (9.13 KB, patch)
2011-11-15 15:03 PST, Erik Arvidsson 		ojan: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2011-11-14 12:07:19 PST 
JS Test Harness: Use a data url for the stylesheet to reduce flakiness
Comment 1 Erik Arvidsson 2011-11-14 12:21:46 PST 
Created attachment 115001 [details]
Patch
Comment 2 Ojan Vafai 2011-11-14 13:48:18 PST 
Comment on attachment 115001 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115001&action=review

> LayoutTests/ChangeLog:7
> +

Can you add more details here about how this reduces flakiness? Just a couple lines that matches what you told me in person.

> LayoutTests/ChangeLog:9
> +        ():

FYI, in the future, you can remove these dummy lines. The prepare-changelog parsing doesn't work very well for JS.
Comment 3 Erik Arvidsson 2011-11-15 15:03:43 PST 
Created attachment 115260 [details]
Patch
Comment 4 Ojan Vafai 2011-11-15 16:02:12 PST 
Comment on attachment 115260 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115260&action=review

> LayoutTests/ChangeLog:7
> +

Still need a short description of why this reduces flakiness.
Comment 5 Erik Arvidsson 2011-11-15 16:45:58 PST 
Committed r100369: <http://trac.webkit.org/changeset/100369>