RESOLVED FIXED 72125
Web Inspector: reimplement DOM search using no XPath. 
https://bugs.webkit.org/show_bug.cgi?id=72125
Summary Web Inspector: reimplement DOM search using no XPath.
Pavel Feldman
Reported 2011-11-11 07:57:41 PST
Patch to follow.
Attachments
Patch (16.14 KB, patch)
2011-11-11 08:16 PST, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-11-11 08:16:03 PST
Created attachment 114702 [details] Patch
Yury Semikhatsky
Comment 2 2011-11-11 09:03:57 PST
Comment on attachment 114702 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114702&action=review > Source/WebCore/inspector/InspectorDOMAgent.cpp:793 > + if (!whitespaceTrimmedQuery.find("//")) { Can we always fall back to XPath as before, otherwise it may be confusing that we limit supported XPath patterns to "//..."? > Source/WebCore/inspector/InspectorDOMAgent.cpp:856 > + const Attribute *attribute = attrMap->attributeItem(i); const Attribute* attribute for consistency with other places.
Pavel Feldman
Comment 3 2011-11-11 09:18:37 PST
Committed r99983: <http://trac.webkit.org/changeset/99983>
Note You need to log in before you can comment on or make changes to this bug.