Bug 72092 - [CMAKE] Add a missing file to PlatformEfl.cmake for curl network backend.
Summary: [CMAKE] Add a missing file to PlatformEfl.cmake for curl network backend.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-10 22:57 PST by Gyuyoung Kim
Modified: 2011-11-11 17:15 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.46 KB, patch)
2011-11-10 22:59 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (1.46 KB, patch)
2011-11-10 23:28 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2011-11-10 22:57:14 PST 
ProxyServerCurl.cpp file is not included in PlatformEfl.cmake. So, the file is not built when EFL port uses curl as network backend.
Comment 1 Gyuyoung Kim 2011-11-10 22:59:26 PST 
Created attachment 114632 [details]
Patch
Comment 2 Gyuyoung Kim 2011-11-10 23:01:12 PST 
CC'ing Patric.Ryuan and Kubo.
Comment 3 Patrick R. Gansterer 2011-11-10 23:19:35 PST 
Comment on attachment 114632 [details]
Patch

LGTM. BTW: IMHO that's a simple build fix and does not need a review.
Comment 4 Gyuyoung Kim 2011-11-10 23:25:11 PST 
(In reply to comment #3)
> (From update of attachment 114632 [details])
> LGTM. BTW: IMHO that's a simple build fix and does not need a review.

I think so. Ok, I will push this patch without review. Thank you.
Comment 5 Gyuyoung Kim 2011-11-10 23:28:42 PST 
Created attachment 114634 [details]
Patch
Comment 6 WebKit Review Bot 2011-11-11 17:15:20 PST 
Comment on attachment 114634 [details]
Patch

Clearing flags on attachment: 114634

Committed r100049: <http://trac.webkit.org/changeset/100049>
Comment 7 WebKit Review Bot 2011-11-11 17:15:24 PST 
All reviewed patches have been landed.  Closing bug.