WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
72092
[CMAKE] Add a missing file to PlatformEfl.cmake for curl network backend.
https://bugs.webkit.org/show_bug.cgi?id=72092
Summary
[CMAKE] Add a missing file to PlatformEfl.cmake for curl network backend.
Gyuyoung Kim
Reported
2011-11-10 22:57:14 PST
ProxyServerCurl.cpp file is not included in PlatformEfl.cmake. So, the file is not built when EFL port uses curl as network backend.
Attachments
Patch
(1.46 KB, patch)
2011-11-10 22:59 PST
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
Patch
(1.46 KB, patch)
2011-11-10 23:28 PST
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1
2011-11-10 22:59:26 PST
Created
attachment 114632
[details]
Patch
Gyuyoung Kim
Comment 2
2011-11-10 23:01:12 PST
CC'ing Patric.Ryuan and Kubo.
Patrick R. Gansterer
Comment 3
2011-11-10 23:19:35 PST
Comment on
attachment 114632
[details]
Patch LGTM. BTW: IMHO that's a simple build fix and does not need a review.
Gyuyoung Kim
Comment 4
2011-11-10 23:25:11 PST
(In reply to
comment #3
)
> (From update of
attachment 114632
[details]
) > LGTM. BTW: IMHO that's a simple build fix and does not need a review.
I think so. Ok, I will push this patch without review. Thank you.
Gyuyoung Kim
Comment 5
2011-11-10 23:28:42 PST
Created
attachment 114634
[details]
Patch
WebKit Review Bot
Comment 6
2011-11-11 17:15:20 PST
Comment on
attachment 114634
[details]
Patch Clearing flags on attachment: 114634 Committed
r100049
: <
http://trac.webkit.org/changeset/100049
>
WebKit Review Bot
Comment 7
2011-11-11 17:15:24 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug